Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Group Shapes & Custom Connection Things #107

Open
Graywaren opened this issue Sep 22, 2024 · 4 comments
Open

[FR] Group Shapes & Custom Connection Things #107

Graywaren opened this issue Sep 22, 2024 · 4 comments
Labels
feature request New feature or request

Comments

@Graywaren
Copy link

Graywaren commented Sep 22, 2024

Hi
I love your plug-in and am so glad it (and others) exists so I can hammer obsidian into doing what I want 😅. I have a few feature requests I'd love to see implemented so far.

  • I'd love to see the ability to change group card shape added in the menu the way that it is for individual cards. I've recently been doing venn diagrams with canvas and needed to have groups be circles. I was able to achieve it with the custom styling your plug in adds thankfully, but I'd really love to see the easy menu with the various different shapes be accessible with a simple couple of clicks in the menu.

Also, I'm not sure if these were requested before or if either are possible, but I would desperately love:

  • To be able to create, then click & drag points on the connection lines to rearrange them, similar to how you can add points to a vector line in photoshop, so that I can have them avoid going behind other cards or make fancy shapes and whatnot.
  • To be able to have them connect anywhere on the edge of a card so I can have multiple separate lines going off from any card rather than just one per side where they all must converge.

Thanks so much for such a wonderful plug-in. I'm looking forward to seeing what you add in the future!

@Developer-Mike
Copy link
Owner

Thank you for the feedback 🙏🏻

Although adding shapes to groups would be possible without much work (https://github.com/Developer-Mike/obsidian-advanced-canvas/blob/main/src%2Fcanvas-extensions%2Fadvanced-styles%2Fstyle-config.ts#L42). It comes with some problems like the detection of containing nodes.

Adding anchors to edges is also planned and nearly ready to release.

I have some ideas regarding multiple attachment points for nodes, but it will take a while before this feature gets implemented.

@Developer-Mike Developer-Mike added the feature request New feature or request label Oct 3, 2024
@Graywaren
Copy link
Author

By detection of containing nodes, do you mean that having the shapes make it more difficult to detect which nodes in it should move with it?

Not sure if this is helpful, but I did make a custom class that turns the shape of groups into the circle/oval that I use as my work around for this, and it's been working really well so far. I've not noticed any issue with it not moving nodes it should or moving ones it shouldn't. Admittedly, I haven't done anything very fancy or extensive with it, but it moves my single line text nodes that are entirely inside the border of the circle and doesn't move ones that aren't entirely inside it, which is how I'd expect it to work. It's been working great for venn diagrams and bubble plot type things. I could be totally wrong since I'm unfamiliar with the code, but that would at least indicate to me that at least the circular shape would be less likely to have any issues.

Could you clarify what "edges" means? I've seen it a number of times but have never been able to figure out if it means the lines you can connect nodes with or the edges of the node containers themselves >.>

If it's the lines/arrows, does that mean being able to customize where they're going is what is nearly ready? Multiple attachment points sounds like the second part, that will take a while. Just making sure I understand lol. Very cool to have something almost ready!

At least when it comes to the multiple attachment points my partner showed me a hack (have an empty node behind it to line up where you want the extra point), that I can use in the interim!

@Developer-Mike
Copy link
Owner

Huh? I could have bet that I replied... Sorry for the delay.

I'll take a look at the group shapes but I think you haven't encountered some edge cases.

The canvas consists of edges and nodes. So the edges are the lines you can connect nodes with.

Although I've something ready for the edge path anchors, I think I'll discard it and take another, better approach.

I'm glad you've found a partial solution for the limited connection points.

Because I'm the only one working on this project, it's very very difficult to provide any ETAs. I hope you understand.

@Graywaren
Copy link
Author

No worries! I totally understand, and honestly I think people who make free plug-ins and maintain them deserve medals of honor lol. If there's anything I can test for you, feel free to ping me. I'm known for running into the most obscure bugs 😅 Looking forward to the new features whenever you deem them ready. Thanks again for making such a cool plug in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants