Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check equalities for shells and volume model #421

Open
masfaraud opened this issue Jun 29, 2022 · 3 comments
Open

check equalities for shells and volume model #421

masfaraud opened this issue Jun 29, 2022 · 3 comments
Milestone

Comments

@masfaraud
Copy link
Contributor

masfaraud commented Jun 29, 2022

in some case it seem that equalities does not work well (pointer_memos) on Closed shell or volume modes
-> Check if eq is properly configured (non serializable_attributes...)
problematic case: shell is a colection of triangles (coming from a stl file)

@MackJoly
Copy link
Contributor

MackJoly commented Jun 29, 2022

Here is an example of what append using pointers_analysis
image

@MackJoly
Copy link
Contributor

MackJoly commented Aug 8, 2022

I think that a Face3D that inherits from closedShell3D with color doesn't recognize itself :
face.to_dict() #face from a closedShell3D with color
Out[43]:
{'name': '',
'object_class': 'volmdlr.faces.Triangle3D',
'package_version': '0.4.1.dev614+ga751ebe4',
'point1': {'object_class': 'volmdlr.Point3D',
'x': -0.34456532197840073,
'y': -0.4458999938964844,
'z': 0.30322941140567555,
'name': ''},
'point2': {'object_class': 'volmdlr.Point3D',
'x': -0.25828048095703127,
'y': -0.4458999938964844,
'z': 0.3327346343994141,
'name': ''},
'point3': {'object_class': 'volmdlr.Point3D',
'x': -0.2691668212890625,
'y': -0.4458999938964844,
'z': 0.3309088562011719,
'name': ''}}

face._check_platform()
data diff: ([], [], ['#/alpha'])

No problem with a closedShell3D without color

I can't reproduce the problem with a Shell with color

@masfaraud masfaraud added this to the Long term milestone Oct 5, 2022
@WirajanDASILVA
Copy link
Collaborator

@masfaraud is this still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants