Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create curves/edges intersections convention #1159

Open
1 of 2 tasks
GabrielJMS opened this issue Nov 23, 2023 · 0 comments
Open
1 of 2 tasks

Create curves/edges intersections convention #1159

GabrielJMS opened this issue Nov 23, 2023 · 0 comments

Comments

@GabrielJMS
Copy link
Contributor

GabrielJMS commented Nov 23, 2023

  • I'm submitting a ...

    • bug report
    • feature request
  • What is the current behavior?
    Today, if there are more than one intersection points between two curves/edges, there is no convention stablished about the order that intersection points are returned (it can be in the self or of the other instance, passed as argument, abscissa ascending order). This often requires additional verification steps in subsequent methods, introducing unnecessary complexity and potentially affecting performance.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem Avoid reference to other packages

  • What is the expected behavior?
    I suggest adopting a convention to always return intersection points ordered by the abscissa of the self instance. This convention will not only enhance code readability but also eliminate the need for redundant checks in methods that utilize intersection results.

  • What is the motivation / use case for changing the behavior?
    Improve performance: We can try to code our methods respecting the convention adopted, reducing the needs of post-traitement
    Reduced redundancy: With a standardized convention, there's no need for additional verification steps in methods that call intersection functions.

  • Possible fixes

  • Please tell us about your environment:

    • branch:
    • commit:
    • python version:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants