Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code not killed if CodeEngine.kill() called before Code.run() resolves #16

Open
marusshi opened this issue May 30, 2018 · 0 comments
Open

Code not killed if CodeEngine.kill() called before Code.run() resolves #16

marusshi opened this issue May 30, 2018 · 0 comments
Labels
bug

Comments

@marusshi
Copy link
Collaborator

Scenario:

CodeEngine receives a run_code command -> CodeEngine.kill() called -> Code.kill() is called on all running code for this engine -> Code.run() didn't finish resolving yet, so Code.kill() does not kill the code that is about to run because Code.processes hasn't been updated -> Error thrown once code begins to run with a 'killed' CodeEngine

(node:9036) UnhandledPromiseRejectionWarning: Error: client disconnecting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marusshi