Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose functionality to clip HorizontalFlowBarrier class #1414

Open
JoerivanEngelen opened this issue Feb 6, 2025 · 0 comments
Open

Expose functionality to clip HorizontalFlowBarrier class #1414

JoerivanEngelen opened this issue Feb 6, 2025 · 0 comments

Comments

@JoerivanEngelen
Copy link
Contributor

We have quite some internal logic to clip HorizontalFlowBarrier packages away from inactive cells. However, it isn't really exposed to the user. Right now we throw validation errors when barriers are intersecting a grid. When users set strict_hfb_validation to false, the models run without error as barrier segments connecting to inactive cells are filtered away. The latter is hard to do when running models with primod (probably worthy of its own issue).

I see two ways we could do this. Either by modifying the already existing mask method, which at present doesn't do anything because vector data is independent from grid. I therefore is quite a useless method right now, just existing to keep the API consistent. The other way we could go by this is introduce a cleanup_hfb function, which takes a grid an cleans it based on that. Or both?

@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Feb 6, 2025
@JoerivanEngelen JoerivanEngelen changed the title Expose functinionality to clip HorizontalFlowBarrier class Expose functionality to clip HorizontalFlowBarrier class Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📯 New
Development

No branches or pull requests

1 participant