Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1409 enforce 2d msw cell area call #1418

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Issue #1409 enforce 2d msw cell area call #1418

merged 7 commits into from
Feb 12, 2025

Conversation

JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented Feb 7, 2025 •
edited
Loading

Fixes #1409

Description

Turned out this error was caused by a call to imod.mf6.Recharge.from_imod5_data where layer dim in cap data was not dropped.

  • Drop "layer" dim and/or coord in imod.mf6.Recharge.from_imod5_data in cap data
  • Do this also for imod.mf6.LayeredWell.from_imod5_data, in preparation for Sprinkling.from_imod5_data doesn't convert units #1411
  • Add shortcut for drop layer function to shortcut for pd.DataFrame
  • Move msw select layer select utilites to imo.util.dims module to avoid circular import
  • Rename variable type to artificial_rch_type to avoid overriding builtin (thanks Sonarcloud)

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

@JoerivanEngelen
Issue #1411 fix unit conversion sprinkling (#1419)
37644fb 
Fixes #1411

# Description
- Convert mm/d to m3/d for sprinkling wells
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JoerivanEngelen
Copy link
Contributor Author

Merging this, one unittests failed, but that is because of a flaky irrelevant test.

@JoerivanEngelen JoerivanEngelen merged commit ec2a335 into master Feb 12, 2025
6 of 7 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1409_enforce_2d_msw_cell_area_call branch February 12, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manangka Manangka Manangka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

msw utility get_cell_area_from_imod5_data should drop layer coord when computing cell area
2 participants
@JoerivanEngelen @Manangka