Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactor TOML configuration file #547

Merged
merged 9 commits into from
Feb 11, 2025
Merged

Small refactor TOML configuration file #547

merged 9 commits into from
Feb 11, 2025

Conversation

vers-w
Copy link
Collaborator

@vers-w vers-w commented Feb 5, 2025

Issue addressed

Fixes #542

Only use `input.forcing` in the TOML file (removed list of internal forcing variables below `input.dynamic` entry).
Only use `input.cyclic` in the TOML file (removed `input.dynamic` entry).
For function `lens_input_parameter` as it is not possible to distinguish between cyclic or static model input parameter.
Error thrown for functions `lens_input_parameter` and `lens_input` for required input model parameters but not set in TOML file.
A bit more strict. For example for output, check if all required TOML sections are set. For states reading check if state section in TOML file is complete.
More explicit, all starting with `output` including info on file format/data type (scalar or grid for netCDF).
@vers-w vers-w marked this pull request as ready for review February 10, 2025 07:15
@vers-w vers-w requested a review from JoostBuitink February 10, 2025 07:15
Copy link
Contributor

@JoostBuitink JoostBuitink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes, it is a very nice improvement to the TOML! LGTM!

@vers-w vers-w merged commit b8383d8 into master Feb 11, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small refactor configuration TOML file
2 participants