You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
When we compare the exported properties of a declaration and JS source, we ignore the prototype property. This means that if the module is a class, we don't compare the class members to see if they match. For example:
js
We don't detect that name method is missing from the d.ts because we ignore the members of prototype in the JS inferred module type. To account for name, we should do something like
jsExportType.members.get("prototype").type.getProperties(); // returns symbols for properties 'x' and 'name' above
The text was updated successfully, but these errors were encountered:
gabritto
changed the title
Consider prototype properties when matching declaration against JS source
Consider 'prototype' property when matching declaration against JS source
Mar 3, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When we compare the exported properties of a declaration and JS source, we ignore the
prototype
property. This means that if the module is a class, we don't compare the class members to see if they match. For example:js
d.ts
We don't detect that
name
method is missing from the d.ts because we ignore the members ofprototype
in the JS inferred module type. To account forname
, we should do something likeThe text was updated successfully, but these errors were encountered: