Requiring owner approval for critical-to-an-ecosystem types

[chriskrycho]

Picking up a thread from this Discord discussion from about a month ago (!)—

Per @elibarzilay, the current bot system has a danger level and a popularity level, which combine to allow lower-popularity (non-"critical" or "popular") type definitions to be merged by any reviewer. While this makes a certain amount of sense, hinging on popularity means that type definitions which may be critical to a given audience can have changes slip through.

As the motivating example, the types for ember, @ember/*, ember-data, and @ember-data/* are critical to the experience of the entire Ember ecosystem—including JS users, courtesy of VS Code's automatic type acquisition. Ember is relatively low in popularity compared to e.g. React, but its core types still need owner review to be allowed through, because of their impact to the whole system.

For our use case, it would be helpful to be able to mark that a given set of types always requires owner approval, regardless of popularity; or to otherwise simplify the rule sets in some way. We're fairly agnostic on the details of the solution; we just don't want random well-intentioned reviewers to accidentally get code merged!

cc. @dfreeman @jamescdavis

[elibarzilay]

cc @RyanCavanaugh, @orta.

[jpoehnelt]

This is also important for types that do not have an associated npm package and thus no popularity level.