From 100ec13c0f2da311a51d73a10f33b1407b5eea83 Mon Sep 17 00:00:00 2001 From: Jack Bates Date: Wed, 9 Dec 2020 11:38:55 -0700 Subject: [PATCH] Update snapshots --- src/_tests/fixtures/38979/derived.json | 8 +++- src/_tests/fixtures/38979/mutations.json | 32 +++++++++++++- src/_tests/fixtures/38979/result.json | 13 +++++- src/_tests/fixtures/43136/result.json | 2 +- src/_tests/fixtures/43144/result.json | 2 +- src/_tests/fixtures/43151/derived.json | 8 +++- src/_tests/fixtures/43151/mutations.json | 30 +++++++++++++ src/_tests/fixtures/43151/result.json | 11 ++++- src/_tests/fixtures/43160/result.json | 2 +- src/_tests/fixtures/43175/result.json | 2 +- src/_tests/fixtures/43235/result.json | 2 +- src/_tests/fixtures/43314/derived.json | 8 +++- src/_tests/fixtures/43314/mutations.json | 30 +++++++++++++ src/_tests/fixtures/43314/result.json | 11 ++++- .../43695-duplicate-comment/derived.json | 8 +++- .../43695-duplicate-comment/mutations.json | 30 +++++++++++++ .../43695-duplicate-comment/result.json | 11 ++++- .../fixtures/43695-post-review/derived.json | 8 +++- .../fixtures/43695-post-review/mutations.json | 30 +++++++++++++ .../fixtures/43695-post-review/result.json | 11 ++++- src/_tests/fixtures/43695/derived.json | 8 +++- src/_tests/fixtures/43695/mutations.json | 30 +++++++++++++ src/_tests/fixtures/43695/result.json | 11 ++++- .../fixtures/43960-post-close/result.json | 2 +- src/_tests/fixtures/43960/result.json | 2 +- src/_tests/fixtures/44105/result.json | 2 +- src/_tests/fixtures/44256/result.json | 2 +- src/_tests/fixtures/44267/result.json | 2 +- src/_tests/fixtures/44282/result.json | 2 +- src/_tests/fixtures/44288/result.json | 2 +- src/_tests/fixtures/44290/result.json | 2 +- .../fixtures/44299-with-files/derived.json | 8 +++- .../fixtures/44299-with-files/mutations.json | 30 +++++++++++++ .../fixtures/44299-with-files/result.json | 11 ++++- src/_tests/fixtures/44299/derived.json | 12 ++++-- src/_tests/fixtures/44299/mutations.json | 40 ++++++++++++++++++ src/_tests/fixtures/44299/result.json | 15 ++++++- src/_tests/fixtures/44316/derived.json | 4 +- src/_tests/fixtures/44316/mutations.json | 20 +++++++++ src/_tests/fixtures/44316/result.json | 7 +++- .../fixtures/44343-pending-travis/result.json | 2 +- .../fixtures/44343-pre-travis/result.json | 2 +- src/_tests/fixtures/44343/result.json | 2 +- src/_tests/fixtures/44402/result.json | 2 +- src/_tests/fixtures/44411/derived.json | 8 +++- src/_tests/fixtures/44411/mutations.json | 32 +++++++++++++- src/_tests/fixtures/44411/result.json | 13 +++++- .../derived.json | 12 ++++-- .../mutations.json | 42 ++++++++++++++++++- .../result.json | 17 +++++++- .../44424-2-after-travis-second/derived.json | 12 ++++-- .../mutations.json | 42 ++++++++++++++++++- .../44424-2-after-travis-second/result.json | 17 +++++++- src/_tests/fixtures/44437/result.json | 2 +- src/_tests/fixtures/44439/result.json | 2 +- src/_tests/fixtures/44631/result.json | 2 +- src/_tests/fixtures/44857/result.json | 2 +- src/_tests/fixtures/44989-14days/result.json | 2 +- src/_tests/fixtures/44989-32days/result.json | 2 +- src/_tests/fixtures/44989-3days/result.json | 2 +- src/_tests/fixtures/44989-7days/result.json | 2 +- src/_tests/fixtures/45137/result.json | 2 +- src/_tests/fixtures/45627/result.json | 2 +- src/_tests/fixtures/45836/result.json | 2 +- src/_tests/fixtures/45884/result.json | 2 +- src/_tests/fixtures/45888/result.json | 2 +- src/_tests/fixtures/45890/derived.json | 8 +++- src/_tests/fixtures/45890/mutations.json | 30 +++++++++++++ src/_tests/fixtures/45890/result.json | 11 ++++- src/_tests/fixtures/45946/derived.json | 8 +++- src/_tests/fixtures/45946/mutations.json | 30 +++++++++++++ src/_tests/fixtures/45946/result.json | 11 ++++- src/_tests/fixtures/45982/result.json | 2 +- src/_tests/fixtures/45999/result.json | 2 +- src/_tests/fixtures/46008/result.json | 2 +- src/_tests/fixtures/46019/derived.json | 4 +- src/_tests/fixtures/46019/mutations.json | 20 +++++++++ src/_tests/fixtures/46019/result.json | 7 +++- src/_tests/fixtures/46120/result.json | 2 +- src/_tests/fixtures/46191/result.json | 2 +- src/_tests/fixtures/46196/result.json | 2 +- src/_tests/fixtures/46279/result.json | 2 +- src/_tests/fixtures/46804/result.json | 2 +- src/_tests/fixtures/46879/result.json | 2 +- .../47017-blessed-and-one-owner/result.json | 2 +- .../47017-blessed-and-two-owner/result.json | 2 +- src/_tests/fixtures/47017-blessed/result.json | 2 +- src/_tests/fixtures/47017/result.json | 2 +- src/_tests/fixtures/48216/result.json | 2 +- src/_tests/fixtures/48236/result.json | 2 +- .../fixtures/48652-merge-offer/result.json | 2 +- src/_tests/fixtures/48652-prereq/result.json | 2 +- .../result.json | 2 +- .../48652-retract-merge-offer/result.json | 2 +- src/_tests/fixtures/48708/result.json | 2 +- src/_tests/fixtures/48945/result.json | 2 +- src/_tests/fixtures/49417/result.json | 2 +- src/_tests/fixtures/49548/result.json | 2 +- src/_tests/fixtures/49639/derived.json | 10 ++--- src/_tests/fixtures/49639/mutations.json | 6 +-- src/_tests/fixtures/49639/result.json | 8 ++-- src/_tests/fixtures/49841/derived.json | 5 +-- src/_tests/fixtures/49841/mutations.json | 2 +- src/_tests/fixtures/49841/result.json | 4 +- 104 files changed, 784 insertions(+), 126 deletions(-) diff --git a/src/_tests/fixtures/38979/derived.json b/src/_tests/fixtures/38979/derived.json index 43f348811..be0ff8225 100644 --- a/src/_tests/fixtures/38979/derived.json +++ b/src/_tests/fixtures/38979/derived.json @@ -299,12 +299,16 @@ { "path": "types/es-abstract/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/es-abstract/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [ diff --git a/src/_tests/fixtures/38979/mutations.json b/src/_tests/fixtures/38979/mutations.json index 265ca4551..643834bd3 100644 --- a/src/_tests/fixtures/38979/mutations.json +++ b/src/_tests/fixtures/38979/mutations.json @@ -36,7 +36,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxMg==", - "body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc), [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -66,5 +66,35 @@ "body": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @RReverser.)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", + "path": "types/es-abstract/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", + "path": "types/es-abstract/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", + "body": "@ExE-Boss I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/38979/result.json b/src/_tests/fixtures/38979/result.json index 9701e6e53..b72621154 100644 --- a/src/_tests/fixtures/38979/result.json +++ b/src/_tests/fixtures/38979/result.json @@ -10,7 +10,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc), [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", @@ -25,7 +25,16 @@ "status": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @RReverser.)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/es-abstract/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/es-abstract/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43136/result.json b/src/_tests/fixtures/43136/result.json index 01d1bdf1c..1dfd4a9aa 100644 --- a/src/_tests/fixtures/43136/result.json +++ b/src/_tests/fixtures/43136/result.json @@ -18,7 +18,7 @@ "status": "@RReverser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43144/result.json b/src/_tests/fixtures/43144/result.json index 3e3af8bdf..9602d7d7b 100644 --- a/src/_tests/fixtures/43144/result.json +++ b/src/_tests/fixtures/43144/result.json @@ -15,7 +15,7 @@ "status": "@jeffreymeng Everything looks good here. Great job! I am ready to merge this PR (at f1f5c4b) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@pocesar: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43151/derived.json b/src/_tests/fixtures/43151/derived.json index dbed97b8e..7498101a3 100644 --- a/src/_tests/fixtures/43151/derived.json +++ b/src/_tests/fixtures/43151/derived.json @@ -27,12 +27,16 @@ { "path": "types/gaze/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/gaze/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/43151/mutations.json b/src/_tests/fixtures/43151/mutations.json index 31333f765..72cebc654 100644 --- a/src/_tests/fixtures/43151/mutations.json +++ b/src/_tests/fixtures/43151/mutations.json @@ -36,5 +36,35 @@ "body": "🔔 @adamzerella — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5", + "path": "types/gaze/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5", + "path": "types/gaze/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5", + "body": "@adamzerella I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/43151/result.json b/src/_tests/fixtures/43151/result.json index b18c19264..bfe306c3c 100644 --- a/src/_tests/fixtures/43151/result.json +++ b/src/_tests/fixtures/43151/result.json @@ -14,7 +14,16 @@ "status": "🔔 @adamzerella — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/gaze/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/gaze/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43160/result.json b/src/_tests/fixtures/43160/result.json index 6b46e6835..dc0f263dc 100644 --- a/src/_tests/fixtures/43160/result.json +++ b/src/_tests/fixtures/43160/result.json @@ -20,7 +20,7 @@ "status": "@rikkertkoppes The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/22c73c88cc9c09efd4c2998ec360607dd4c36c2e/checks?check_suite_id=731664306).\r\n\r\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43175/result.json b/src/_tests/fixtures/43175/result.json index 3ac82319a..433d9f119 100644 --- a/src/_tests/fixtures/43175/result.json +++ b/src/_tests/fixtures/43175/result.json @@ -23,7 +23,7 @@ "status": "@couven92 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43235/result.json b/src/_tests/fixtures/43235/result.json index f4e4b9d40..b165bc470 100644 --- a/src/_tests/fixtures/43235/result.json +++ b/src/_tests/fixtures/43235/result.json @@ -12,7 +12,7 @@ "status": "🔔 @Esri @bsvensson — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43235/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43314/derived.json b/src/_tests/fixtures/43314/derived.json index e2604a37a..21246e78e 100644 --- a/src/_tests/fixtures/43314/derived.json +++ b/src/_tests/fixtures/43314/derived.json @@ -27,12 +27,16 @@ { "path": "types/carbon__icon-helpers/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/carbon__icon-helpers/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/43314/mutations.json b/src/_tests/fixtures/43314/mutations.json index b23d1ee8e..4c4ac3502 100644 --- a/src/_tests/fixtures/43314/mutations.json +++ b/src/_tests/fixtures/43314/mutations.json @@ -25,5 +25,35 @@ "body": "🔔 @metonym — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzkyMDM2NjA4", + "path": "types/carbon__icon-helpers/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzkyMDM2NjA4", + "path": "types/carbon__icon-helpers/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzkyMDM2NjA4", + "body": "@metonym I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/43314/result.json b/src/_tests/fixtures/43314/result.json index 522e5880a..fd80fa24a 100644 --- a/src/_tests/fixtures/43314/result.json +++ b/src/_tests/fixtures/43314/result.json @@ -14,7 +14,16 @@ "status": "🔔 @metonym — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/carbon__icon-helpers/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/carbon__icon-helpers/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43695-duplicate-comment/derived.json b/src/_tests/fixtures/43695-duplicate-comment/derived.json index d9abd3aa2..322c0f556 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/derived.json +++ b/src/_tests/fixtures/43695-duplicate-comment/derived.json @@ -27,12 +27,16 @@ { "path": "types/accedo__accedo-one/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/accedo__accedo-one/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/43695-duplicate-comment/mutations.json b/src/_tests/fixtures/43695-duplicate-comment/mutations.json index 8e6013488..76bf77389 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/mutations.json +++ b/src/_tests/fixtures/43695-duplicate-comment/mutations.json @@ -66,5 +66,35 @@ "body": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @alexandercerutti.\n\n(Ping «anyone?».)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "body": "@alexandercerutti I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/43695-duplicate-comment/result.json b/src/_tests/fixtures/43695-duplicate-comment/result.json index e4c12a9a8..df758869d 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/result.json +++ b/src/_tests/fixtures/43695-duplicate-comment/result.json @@ -23,7 +23,16 @@ "status": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @alexandercerutti.\n\n(Ping «anyone?».)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43695-post-review/derived.json b/src/_tests/fixtures/43695-post-review/derived.json index b0c3caeaf..1ed9b0461 100644 --- a/src/_tests/fixtures/43695-post-review/derived.json +++ b/src/_tests/fixtures/43695-post-review/derived.json @@ -27,12 +27,16 @@ { "path": "types/accedo__accedo-one/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/accedo__accedo-one/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/43695-post-review/mutations.json b/src/_tests/fixtures/43695-post-review/mutations.json index 34863d491..50e76351b 100644 --- a/src/_tests/fixtures/43695-post-review/mutations.json +++ b/src/_tests/fixtures/43695-post-review/mutations.json @@ -25,5 +25,35 @@ "body": "@alexandercerutti One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "body": "@alexandercerutti I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/43695-post-review/result.json b/src/_tests/fixtures/43695-post-review/result.json index 8b565cc6d..5ec08cd99 100644 --- a/src/_tests/fixtures/43695-post-review/result.json +++ b/src/_tests/fixtures/43695-post-review/result.json @@ -15,7 +15,16 @@ "status": "@alexandercerutti One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43695/derived.json b/src/_tests/fixtures/43695/derived.json index c4e340d10..efd8f3a66 100644 --- a/src/_tests/fixtures/43695/derived.json +++ b/src/_tests/fixtures/43695/derived.json @@ -27,12 +27,16 @@ { "path": "types/accedo__accedo-one/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/accedo__accedo-one/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/43695/mutations.json b/src/_tests/fixtures/43695/mutations.json index 93bd5c240..241528b61 100644 --- a/src/_tests/fixtures/43695/mutations.json +++ b/src/_tests/fixtures/43695/mutations.json @@ -25,5 +25,35 @@ "body": "@alexandercerutti One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "body": "@alexandercerutti I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/43695/result.json b/src/_tests/fixtures/43695/result.json index fb438db7e..8889e96da 100644 --- a/src/_tests/fixtures/43695/result.json +++ b/src/_tests/fixtures/43695/result.json @@ -15,7 +15,16 @@ "status": "@alexandercerutti One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43960-post-close/result.json b/src/_tests/fixtures/43960-post-close/result.json index 295c8db3f..625c6ab75 100644 --- a/src/_tests/fixtures/43960-post-close/result.json +++ b/src/_tests/fixtures/43960-post-close/result.json @@ -2,7 +2,7 @@ "pr_number": 43960, "labels": [], "responseComments": [], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/43960/result.json b/src/_tests/fixtures/43960/result.json index 2ecddafdc..3787fddb4 100644 --- a/src/_tests/fixtures/43960/result.json +++ b/src/_tests/fixtures/43960/result.json @@ -15,7 +15,7 @@ "status": "@aaltepet One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44105/result.json b/src/_tests/fixtures/44105/result.json index 9a9c73cd0..4e4495b28 100644 --- a/src/_tests/fixtures/44105/result.json +++ b/src/_tests/fixtures/44105/result.json @@ -2,7 +2,7 @@ "pr_number": 44105, "labels": [], "responseComments": [], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/44256/result.json b/src/_tests/fixtures/44256/result.json index 69d95b0ac..762124ffe 100644 --- a/src/_tests/fixtures/44256/result.json +++ b/src/_tests/fixtures/44256/result.json @@ -2,7 +2,7 @@ "pr_number": 44256, "labels": [], "responseComments": [], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/44267/result.json b/src/_tests/fixtures/44267/result.json index 604c6afed..6fe91bf6c 100644 --- a/src/_tests/fixtures/44267/result.json +++ b/src/_tests/fixtures/44267/result.json @@ -15,7 +15,7 @@ "status": "@ErikMartensson Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `intercom-client` [on npm](https://www.npmjs.com/package/intercom-client), [on unpkg](https://unpkg.com/browse/intercom-client@latest/)\n - owner-approval: @malithrw\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44282/result.json b/src/_tests/fixtures/44282/result.json index 62dadebf2..e3f335100 100644 --- a/src/_tests/fixtures/44282/result.json +++ b/src/_tests/fixtures/44282/result.json @@ -15,7 +15,7 @@ "status": "🔔 @fishcharlie — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44282/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44288/result.json b/src/_tests/fixtures/44288/result.json index 703d8b431..84d059024 100644 --- a/src/_tests/fixtures/44288/result.json +++ b/src/_tests/fixtures/44288/result.json @@ -12,7 +12,7 @@ "status": "🔔 @gosticks — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44288/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44290/result.json b/src/_tests/fixtures/44290/result.json index 1409d8f4f..25712ee51 100644 --- a/src/_tests/fixtures/44290/result.json +++ b/src/_tests/fixtures/44290/result.json @@ -2,7 +2,7 @@ "pr_number": 44290, "labels": [], "responseComments": [], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/44299-with-files/derived.json b/src/_tests/fixtures/44299-with-files/derived.json index 88bfd708e..af5f2b919 100644 --- a/src/_tests/fixtures/44299-with-files/derived.json +++ b/src/_tests/fixtures/44299-with-files/derived.json @@ -27,12 +27,16 @@ { "path": "types/hcaptcha__vue-hcaptcha/package.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/hcaptcha__vue-hcaptcha/tslint.json", diff --git a/src/_tests/fixtures/44299-with-files/mutations.json b/src/_tests/fixtures/44299-with-files/mutations.json index 79288d5ad..e1cd0e2c0 100644 --- a/src/_tests/fixtures/44299-with-files/mutations.json +++ b/src/_tests/fixtures/44299-with-files/mutations.json @@ -25,5 +25,35 @@ "body": "🔔 @geopic — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "path": "types/hcaptcha__vue-hcaptcha/package.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "body": "@geopic I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/44299-with-files/result.json b/src/_tests/fixtures/44299-with-files/result.json index 21034e907..70cfdd1fb 100644 --- a/src/_tests/fixtures/44299-with-files/result.json +++ b/src/_tests/fixtures/44299-with-files/result.json @@ -14,7 +14,16 @@ "status": "🔔 @geopic — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/hcaptcha__vue-hcaptcha/package.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44299/derived.json b/src/_tests/fixtures/44299/derived.json index 1bad25eab..9543bd69a 100644 --- a/src/_tests/fixtures/44299/derived.json +++ b/src/_tests/fixtures/44299/derived.json @@ -27,17 +27,23 @@ { "path": "types/hcaptcha__vue-hcaptcha/package.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/hcaptcha__vue-hcaptcha/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/44299/mutations.json b/src/_tests/fixtures/44299/mutations.json index 79288d5ad..396f4c59b 100644 --- a/src/_tests/fixtures/44299/mutations.json +++ b/src/_tests/fixtures/44299/mutations.json @@ -25,5 +25,45 @@ "body": "🔔 @geopic — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "path": "types/hcaptcha__vue-hcaptcha/package.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "path": "types/hcaptcha__vue-hcaptcha/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "body": "@geopic I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/44299/result.json b/src/_tests/fixtures/44299/result.json index 21034e907..516f4f25b 100644 --- a/src/_tests/fixtures/44299/result.json +++ b/src/_tests/fixtures/44299/result.json @@ -14,7 +14,20 @@ "status": "🔔 @geopic — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/hcaptcha__vue-hcaptcha/package.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/hcaptcha__vue-hcaptcha/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44316/derived.json b/src/_tests/fixtures/44316/derived.json index 760ac7528..25c8a58f7 100644 --- a/src/_tests/fixtures/44316/derived.json +++ b/src/_tests/fixtures/44316/derived.json @@ -23,7 +23,9 @@ { "path": "types/vimeo/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/vimeo/vimeo-tests.ts", diff --git a/src/_tests/fixtures/44316/mutations.json b/src/_tests/fixtures/44316/mutations.json index e8ed4fcb2..276081f2b 100644 --- a/src/_tests/fixtures/44316/mutations.json +++ b/src/_tests/fixtures/44316/mutations.json @@ -25,5 +25,25 @@ "body": "🔔 @mattleff — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44316/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMzk4NzAw", + "path": "types/vimeo/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMzk4NzAw", + "body": "@mattleff I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/44316/result.json b/src/_tests/fixtures/44316/result.json index b42412cf8..03e3689d3 100644 --- a/src/_tests/fixtures/44316/result.json +++ b/src/_tests/fixtures/44316/result.json @@ -16,7 +16,12 @@ "status": "🔔 @mattleff — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44316/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/vimeo/tsconfig.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44343-pending-travis/result.json b/src/_tests/fixtures/44343-pending-travis/result.json index 944f8e0fe..653a01822 100644 --- a/src/_tests/fixtures/44343-pending-travis/result.json +++ b/src/_tests/fixtures/44343-pending-travis/result.json @@ -12,7 +12,7 @@ "status": "🔔 @joeriks — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44343/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/44343-pre-travis/result.json b/src/_tests/fixtures/44343-pre-travis/result.json index 944f8e0fe..653a01822 100644 --- a/src/_tests/fixtures/44343-pre-travis/result.json +++ b/src/_tests/fixtures/44343-pre-travis/result.json @@ -12,7 +12,7 @@ "status": "🔔 @joeriks — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44343/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/44343/result.json b/src/_tests/fixtures/44343/result.json index 5631d9dad..ad69ee679 100644 --- a/src/_tests/fixtures/44343/result.json +++ b/src/_tests/fixtures/44343/result.json @@ -12,7 +12,7 @@ "status": "🔔 @joeriks — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44343/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44402/result.json b/src/_tests/fixtures/44402/result.json index d087d2f90..5b9756d06 100644 --- a/src/_tests/fixtures/44402/result.json +++ b/src/_tests/fixtures/44402/result.json @@ -8,7 +8,7 @@ "Edits Infrastructure" ], "responseComments": [], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44411/derived.json b/src/_tests/fixtures/44411/derived.json index d1d2c9d21..11a1920e8 100644 --- a/src/_tests/fixtures/44411/derived.json +++ b/src/_tests/fixtures/44411/derived.json @@ -35,12 +35,16 @@ { "path": "types/jest-image-snapshot/v2/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/jest-image-snapshot/v2/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [ diff --git a/src/_tests/fixtures/44411/mutations.json b/src/_tests/fixtures/44411/mutations.json index 1c26125e1..cf720b026 100644 --- a/src/_tests/fixtures/44411/mutations.json +++ b/src/_tests/fixtures/44411/mutations.json @@ -24,7 +24,37 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMjMzMzI3Ng==", - "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc): couldn't fetch contents\n - [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc), [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMDc3MDI1", + "path": "types/jest-image-snapshot/v2/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMDc3MDI1", + "path": "types/jest-image-snapshot/v2/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMDc3MDI1", + "body": "@peterblazejewicz I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" } } } diff --git a/src/_tests/fixtures/44411/result.json b/src/_tests/fixtures/44411/result.json index f3630a9af..4ee891614 100644 --- a/src/_tests/fixtures/44411/result.json +++ b/src/_tests/fixtures/44411/result.json @@ -8,14 +8,23 @@ "responseComments": [ { "tag": "welcome", - "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc): couldn't fetch contents\n - [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc), [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", "status": "🔔 @dawnmist @erbridge — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [ + { + "path": "types/jest-image-snapshot/v2/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/jest-image-snapshot/v2/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44424-1-travis-instantly-finished/derived.json b/src/_tests/fixtures/44424-1-travis-instantly-finished/derived.json index 82d2c6313..3ca9e8359 100644 --- a/src/_tests/fixtures/44424-1-travis-instantly-finished/derived.json +++ b/src/_tests/fixtures/44424-1-travis-instantly-finished/derived.json @@ -19,7 +19,9 @@ { "path": "types/openfin/OTHER_FILES.txt", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/_v2/api/application/application.d.ts", @@ -172,12 +174,16 @@ { "path": "types/openfin/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/v49/OTHER_FILES.txt", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/v49/_v2/api/application/application.d.ts", diff --git a/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json b/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json index 7a05011a9..060a03a4d 100644 --- a/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json +++ b/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json @@ -13,7 +13,47 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMjUyNzAxNQ==", - "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4), [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03), [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/v49/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "body": "@tomer-openfin I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" } } } diff --git a/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json b/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json index 330a71e2b..bdbd718d2 100644 --- a/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json +++ b/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json @@ -8,14 +8,27 @@ "responseComments": [ { "tag": "welcome", - "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4), [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03), [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", "status": "🔔 @chrisbarker @rdepena @whyn07m3 @licui3936 — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [ + { + "path": "types/openfin/OTHER_FILES.txt", + "body": "couldn't fetch contents" + }, + { + "path": "types/openfin/tslint.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/openfin/v49/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44424-2-after-travis-second/derived.json b/src/_tests/fixtures/44424-2-after-travis-second/derived.json index 803cb9ea7..372b0d3f4 100644 --- a/src/_tests/fixtures/44424-2-after-travis-second/derived.json +++ b/src/_tests/fixtures/44424-2-after-travis-second/derived.json @@ -19,7 +19,9 @@ { "path": "types/openfin/OTHER_FILES.txt", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/_v2/api/application/application.d.ts", @@ -172,12 +174,16 @@ { "path": "types/openfin/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/v49/OTHER_FILES.txt", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/v49/_v2/api/application/application.d.ts", diff --git a/src/_tests/fixtures/44424-2-after-travis-second/mutations.json b/src/_tests/fixtures/44424-2-after-travis-second/mutations.json index bfaaa52cc..a78802cc5 100644 --- a/src/_tests/fixtures/44424-2-after-travis-second/mutations.json +++ b/src/_tests/fixtures/44424-2-after-travis-second/mutations.json @@ -4,7 +4,47 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMjUyNzAxNQ==", - "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4), [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03), [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/v49/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "body": "@tomer-openfin I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" } } } diff --git a/src/_tests/fixtures/44424-2-after-travis-second/result.json b/src/_tests/fixtures/44424-2-after-travis-second/result.json index e035bc40d..989398e43 100644 --- a/src/_tests/fixtures/44424-2-after-travis-second/result.json +++ b/src/_tests/fixtures/44424-2-after-travis-second/result.json @@ -8,14 +8,27 @@ "responseComments": [ { "tag": "welcome", - "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4), [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03), [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", "status": "🔔 @chrisbarker @rdepena @whyn07m3 @licui3936 — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [ + { + "path": "types/openfin/OTHER_FILES.txt", + "body": "couldn't fetch contents" + }, + { + "path": "types/openfin/tslint.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/openfin/v49/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44437/result.json b/src/_tests/fixtures/44437/result.json index d61919052..65173d3fe 100644 --- a/src/_tests/fixtures/44437/result.json +++ b/src/_tests/fixtures/44437/result.json @@ -17,7 +17,7 @@ "status": "@johnnyreilly Everything looks good here. Great job! I am ready to merge this PR (at eb92456) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@Berkays, @unindented, @kamontat, @theweirdone, @whoaa512: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44439/result.json b/src/_tests/fixtures/44439/result.json index fcc51023e..f3befe363 100644 --- a/src/_tests/fixtures/44439/result.json +++ b/src/_tests/fixtures/44439/result.json @@ -15,7 +15,7 @@ "status": "🔔 @lith-light-g — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44439/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44631/result.json b/src/_tests/fixtures/44631/result.json index 6c05c3611..a07ce3e63 100644 --- a/src/_tests/fixtures/44631/result.json +++ b/src/_tests/fixtures/44631/result.json @@ -15,7 +15,7 @@ "status": "@mAAdhaTTah Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44857/result.json b/src/_tests/fixtures/44857/result.json index b92ce2901..ed3f59b83 100644 --- a/src/_tests/fixtures/44857/result.json +++ b/src/_tests/fixtures/44857/result.json @@ -24,7 +24,7 @@ "status": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @Microsoft, @DefinitelyTyped, @jkomyno, @a-tarasyuk, @alvis, @r3nya, @btoueg, @brunoscheufler, @smac89, @touffy, @DeividasBakanas, @eyqs, @Flarna, @Hannes-Magnusson-CK, @KSXGitHub, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @j-oliveras, @bhongy, @chyzwar, @trivikr, @nguymin4, @yoursunny, @qwelias, @Ryan-Willpower, @peterblazejewicz, @addaleax, @JasonHK.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44989-14days/result.json b/src/_tests/fixtures/44989-14days/result.json index 1e497ffe1..1115acbc8 100644 --- a/src/_tests/fixtures/44989-14days/result.json +++ b/src/_tests/fixtures/44989-14days/result.json @@ -21,7 +21,7 @@ "status": "Re-ping @petr-motejlek / @TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @1M0reBug, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @krantisinh, @pirix-gh, @brekk, @nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone, @Nicholaiii:\n\nThis PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it in three weeks if this doesn't happen.\n\n(Note that posting a comment will restart the month-timer again, so avoid doing that if you don't want me to nag you again... or you can just close it or turn it into a draft now.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44989-32days/result.json b/src/_tests/fixtures/44989-32days/result.json index dece6cef3..cb5b6a973 100644 --- a/src/_tests/fixtures/44989-32days/result.json +++ b/src/_tests/fixtures/44989-32days/result.json @@ -21,7 +21,7 @@ "status": "After a month, no one has requested merging the PR 😞. I'm going to assume that the change is not wanted after all, and will therefore close it." } ], - "suggestions": [], + "explanations": [], "shouldClose": true, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44989-3days/result.json b/src/_tests/fixtures/44989-3days/result.json index 1a661ca65..b8f6acc83 100644 --- a/src/_tests/fixtures/44989-3days/result.json +++ b/src/_tests/fixtures/44989-3days/result.json @@ -16,7 +16,7 @@ "status": "@petr-motejlek Everything looks good here. Great job! I am ready to merge this PR (at 9ca6086) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @1M0reBug, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @krantisinh, @pirix-gh, @brekk, @nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone, @Nicholaiii: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44989-7days/result.json b/src/_tests/fixtures/44989-7days/result.json index 42e2d6df4..22ad366db 100644 --- a/src/_tests/fixtures/44989-7days/result.json +++ b/src/_tests/fixtures/44989-7days/result.json @@ -16,7 +16,7 @@ "status": "@petr-motejlek Everything looks good here. Great job! I am ready to merge this PR (at 9ca6086) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @1M0reBug, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @krantisinh, @pirix-gh, @brekk, @nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone, @Nicholaiii: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45137/result.json b/src/_tests/fixtures/45137/result.json index 50f7849f7..d40cae77a 100644 --- a/src/_tests/fixtures/45137/result.json +++ b/src/_tests/fixtures/45137/result.json @@ -18,7 +18,7 @@ "status": "@lirbank Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `mongodb` [on npm](https://www.npmjs.com/package/mongodb), [on unpkg](https://unpkg.com/browse/mongodb@latest/) (author is owner)\n - owner-approval: @LinusU\n - 1 removed owner: ✎@lirbank\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45627/result.json b/src/_tests/fixtures/45627/result.json index 3d0faafea..e09c84be7 100644 --- a/src/_tests/fixtures/45627/result.json +++ b/src/_tests/fixtures/45627/result.json @@ -27,7 +27,7 @@ "status": "After a month, no one has requested merging the PR 😞. I'm going to assume that the change is not wanted after all, and will therefore close it." } ], - "suggestions": [], + "explanations": [], "shouldClose": true, "shouldMerge": true, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45836/result.json b/src/_tests/fixtures/45836/result.json index ad4a16a78..62bf2584a 100644 --- a/src/_tests/fixtures/45836/result.json +++ b/src/_tests/fixtures/45836/result.json @@ -16,7 +16,7 @@ "status": ":passport_control: Hi @mmorearty,\n\nI can't [accept a merge request](https://github.com/DefinitelyTyped/DefinitelyTyped#make-a-pull-request) until the PR has a green CI and was appropriately reviewed. I will let you know once that happens.\n\nThanks, and happy typing!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45884/result.json b/src/_tests/fixtures/45884/result.json index 7b4331762..a28e3b0b7 100644 --- a/src/_tests/fixtures/45884/result.json +++ b/src/_tests/fixtures/45884/result.json @@ -20,7 +20,7 @@ "status": "@sgratzl Everything looks good here. Great job! I am ready to merge this PR (at 1dcf44a) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@phreed, @wy193777, @ypconstante, @janniclas, @cerberuser, @gsbelarus, @peterjferrarotto, @spaxe, @appleparan, @Veckodag: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45888/result.json b/src/_tests/fixtures/45888/result.json index 15f85cb18..bf929b8ee 100644 --- a/src/_tests/fixtures/45888/result.json +++ b/src/_tests/fixtures/45888/result.json @@ -19,7 +19,7 @@ "status": "🔔 @sampsonjoliver @andipaetzold @JiriBalcar @CodeLenny — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45888/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45890/derived.json b/src/_tests/fixtures/45890/derived.json index 628a96201..bb24fa658 100644 --- a/src/_tests/fixtures/45890/derived.json +++ b/src/_tests/fixtures/45890/derived.json @@ -27,12 +27,16 @@ { "path": "types/greek-utils/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/greek-utils/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/45890/mutations.json b/src/_tests/fixtures/45890/mutations.json index 94c5ec258..e4d8acd63 100644 --- a/src/_tests/fixtures/45890/mutations.json +++ b/src/_tests/fixtures/45890/mutations.json @@ -25,5 +25,35 @@ "body": "🔔 @dimkirt — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ0MzI2NjIy", + "path": "types/greek-utils/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ0MzI2NjIy", + "path": "types/greek-utils/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ0MzI2NjIy", + "body": "@dimkirt I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/45890/result.json b/src/_tests/fixtures/45890/result.json index 351bf2a76..295639fdf 100644 --- a/src/_tests/fixtures/45890/result.json +++ b/src/_tests/fixtures/45890/result.json @@ -15,7 +15,16 @@ "status": "🔔 @dimkirt — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/greek-utils/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/greek-utils/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45946/derived.json b/src/_tests/fixtures/45946/derived.json index ebad7c97e..ddec99c5c 100644 --- a/src/_tests/fixtures/45946/derived.json +++ b/src/_tests/fixtures/45946/derived.json @@ -41,12 +41,16 @@ { "path": "types/asynciterator/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/asynciterator/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [ diff --git a/src/_tests/fixtures/45946/mutations.json b/src/_tests/fixtures/45946/mutations.json index c9b9f4aea..0925fb9ba 100644 --- a/src/_tests/fixtures/45946/mutations.json +++ b/src/_tests/fixtures/45946/mutations.json @@ -47,5 +47,35 @@ "body": "🔔 @rubensworks — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ2MDIxMjkw", + "path": "types/asynciterator/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ2MDIxMjkw", + "path": "types/asynciterator/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ2MDIxMjkw", + "body": "@rubensworks I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/45946/result.json b/src/_tests/fixtures/45946/result.json index b873769fa..2ebdcf5c1 100644 --- a/src/_tests/fixtures/45946/result.json +++ b/src/_tests/fixtures/45946/result.json @@ -16,7 +16,16 @@ "status": "🔔 @rubensworks — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/asynciterator/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/asynciterator/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45982/result.json b/src/_tests/fixtures/45982/result.json index 7be9ba77a..be4017f14 100644 --- a/src/_tests/fixtures/45982/result.json +++ b/src/_tests/fixtures/45982/result.json @@ -10,7 +10,7 @@ "status": "@dasa — There was an error that prevented me from properly processing this PR:\n\n error parsing owners: At 1:1 : Expected /\\/\\/ Type definitions for (non-npm package )?/" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45999/result.json b/src/_tests/fixtures/45999/result.json index d7e7f11cc..ca6a0b0c5 100644 --- a/src/_tests/fixtures/45999/result.json +++ b/src/_tests/fixtures/45999/result.json @@ -16,7 +16,7 @@ "status": "@alexpyzhianov Everything looks good here. Great job! I am ready to merge this PR (at 381a2a9) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@johnnyreilly, @bbenezech, @pzavolinsky, @digiguru, @ericanderson, @DovydasNavickas, @theruther4d, @guilhermehubner, @ferdaber, @jrakotoharisoa, @pascaloliv, @hotell, @franklixuefei, @Jessidhia, @saranshkataria, @lukyth, @eps1lon, @zieka, @dancerphil, @dimitropoulos, @disjukr, @vhfmag, @hellatan: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46008/result.json b/src/_tests/fixtures/46008/result.json index 9a2fce5fe..07155bb02 100644 --- a/src/_tests/fixtures/46008/result.json +++ b/src/_tests/fixtures/46008/result.json @@ -20,7 +20,7 @@ "status": "@risingBirdSong Everything looks good here. Great job! I am ready to merge this PR (at 3e19cb9) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@p5-types, @Zalastax: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46019/derived.json b/src/_tests/fixtures/46019/derived.json index cd3e5088e..21e84b13f 100644 --- a/src/_tests/fixtures/46019/derived.json +++ b/src/_tests/fixtures/46019/derived.json @@ -28,7 +28,9 @@ { "path": "types/is-secret/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/is-secret/tslint.json", diff --git a/src/_tests/fixtures/46019/mutations.json b/src/_tests/fixtures/46019/mutations.json index 9f29a4a47..202fce16c 100644 --- a/src/_tests/fixtures/46019/mutations.json +++ b/src/_tests/fixtures/46019/mutations.json @@ -16,5 +16,25 @@ "body": "@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR (at ceca9f7) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ3ODE1MDgx", + "path": "types/is-secret/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ3ODE1MDgx", + "body": "@peterblazejewicz I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/46019/result.json b/src/_tests/fixtures/46019/result.json index 30fb46917..9c709ee1e 100644 --- a/src/_tests/fixtures/46019/result.json +++ b/src/_tests/fixtures/46019/result.json @@ -16,7 +16,12 @@ "status": "@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR (at ceca9f7) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/is-secret/tsconfig.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46120/result.json b/src/_tests/fixtures/46120/result.json index 0369173f2..a3fc677df 100644 --- a/src/_tests/fixtures/46120/result.json +++ b/src/_tests/fixtures/46120/result.json @@ -21,7 +21,7 @@ "status": ":passport_control: Hi @reubenrybnik,\n\nI can't [accept a merge request](https://github.com/DefinitelyTyped/DefinitelyTyped#make-a-pull-request) until the PR has a green CI and was appropriately reviewed. I will let you know once that happens.\n\nThanks, and happy typing!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46191/result.json b/src/_tests/fixtures/46191/result.json index 92cffc648..abeac403f 100644 --- a/src/_tests/fixtures/46191/result.json +++ b/src/_tests/fixtures/46191/result.json @@ -24,7 +24,7 @@ "status": "@jordanoverbye The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/3cc81dbde57a1b0eda6f69f539fa49b8d420adff/checks?check_suite_id=938074936).\r\n\r\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46196/result.json b/src/_tests/fixtures/46196/result.json index 4528e5c4e..d6153fb44 100644 --- a/src/_tests/fixtures/46196/result.json +++ b/src/_tests/fixtures/46196/result.json @@ -12,7 +12,7 @@ "status": "🔔 @HeeL — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46196/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46279/result.json b/src/_tests/fixtures/46279/result.json index d5cc4d4b9..5a644691a 100644 --- a/src/_tests/fixtures/46279/result.json +++ b/src/_tests/fixtures/46279/result.json @@ -20,7 +20,7 @@ "status": "🔔 @pzingg — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46279/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46804/result.json b/src/_tests/fixtures/46804/result.json index 6c62e99db..f673a1c89 100644 --- a/src/_tests/fixtures/46804/result.json +++ b/src/_tests/fixtures/46804/result.json @@ -18,7 +18,7 @@ "status": "🔔 @hrngoode @adina-todoran @BreadAndRoses95 — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46804/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46879/result.json b/src/_tests/fixtures/46879/result.json index 81a657f98..baa937e22 100644 --- a/src/_tests/fixtures/46879/result.json +++ b/src/_tests/fixtures/46879/result.json @@ -14,7 +14,7 @@ "status": "🔔 @sudoplz @GiedriusGrabauskas — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46879/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/47017-blessed-and-one-owner/result.json b/src/_tests/fixtures/47017-blessed-and-one-owner/result.json index 9a0170069..11b309c8b 100644 --- a/src/_tests/fixtures/47017-blessed-and-one-owner/result.json +++ b/src/_tests/fixtures/47017-blessed-and-one-owner/result.json @@ -11,7 +11,7 @@ "status": "@mastermatt Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 2 packages in this PR\n\n* `express-serve-static-core` [on npm](https://www.npmjs.com/package/express-serve-static-core), [on unpkg](https://unpkg.com/browse/express-serve-static-core@latest/)\n - owner-approval: @dwrss\n* `express` [on npm](https://www.npmjs.com/package/express), [on unpkg](https://unpkg.com/browse/express@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ All owners or a DT maintainer needs to approve changes which affect more than one package\n - ✅ express-serve-static-core\n - ❌ express\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/47017-blessed-and-two-owner/result.json b/src/_tests/fixtures/47017-blessed-and-two-owner/result.json index 01cdff040..88b7abf88 100644 --- a/src/_tests/fixtures/47017-blessed-and-two-owner/result.json +++ b/src/_tests/fixtures/47017-blessed-and-two-owner/result.json @@ -17,7 +17,7 @@ "status": "@mastermatt Everything looks good here. Great job! I am ready to merge this PR (at dbe687d) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/47017-blessed/result.json b/src/_tests/fixtures/47017-blessed/result.json index 4d86e07f9..25d285914 100644 --- a/src/_tests/fixtures/47017-blessed/result.json +++ b/src/_tests/fixtures/47017-blessed/result.json @@ -15,7 +15,7 @@ "status": "🔔 @borisyankov @19majkel94 @kacepe @micksatana @samijaber @aereal @JoseLion @dwrss @andoshin11 @CMUH @puneetar @dfrankland — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47017/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/47017/result.json b/src/_tests/fixtures/47017/result.json index 62750ebdc..64f30894e 100644 --- a/src/_tests/fixtures/47017/result.json +++ b/src/_tests/fixtures/47017/result.json @@ -15,7 +15,7 @@ "status": "🔔 @borisyankov @19majkel94 @kacepe @micksatana @samijaber @aereal @JoseLion @dwrss @andoshin11 @CMUH @puneetar @dfrankland — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47017/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48216/result.json b/src/_tests/fixtures/48216/result.json index 332821b18..677644abb 100644 --- a/src/_tests/fixtures/48216/result.json +++ b/src/_tests/fixtures/48216/result.json @@ -12,7 +12,7 @@ "status": "🔔 @innovation-team @rlbaxter — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48216/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48236/result.json b/src/_tests/fixtures/48236/result.json index 68f12242a..d15eae45e 100644 --- a/src/_tests/fixtures/48236/result.json +++ b/src/_tests/fixtures/48236/result.json @@ -19,7 +19,7 @@ "status": "@jablko Everything looks good here. Great job! I am ready to merge this PR (at b4d71f6) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@climba03003: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": true, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48652-merge-offer/result.json b/src/_tests/fixtures/48652-merge-offer/result.json index 69ea0ea80..8208bf5fc 100644 --- a/src/_tests/fixtures/48652-merge-offer/result.json +++ b/src/_tests/fixtures/48652-merge-offer/result.json @@ -21,7 +21,7 @@ "status": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48652-prereq/result.json b/src/_tests/fixtures/48652-prereq/result.json index 4e9c816e3..3cbc1b275 100644 --- a/src/_tests/fixtures/48652-prereq/result.json +++ b/src/_tests/fixtures/48652-prereq/result.json @@ -25,7 +25,7 @@ "status": ":passport_control: Hi @mgol,\n\nI can't [accept a merge request](https://github.com/DefinitelyTyped/DefinitelyTyped#make-a-pull-request) until the PR has a green CI and was appropriately reviewed. I will let you know once that happens.\n\nThanks, and happy typing!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/result.json b/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/result.json index a24d83484..8ebaa9f72 100644 --- a/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/result.json +++ b/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/result.json @@ -19,7 +19,7 @@ "status": ":passport_control: Hi @mgol,\n\nI can't [accept a merge request](https://github.com/DefinitelyTyped/DefinitelyTyped#make-a-pull-request) until the PR has a green CI and was appropriately reviewed. I will let you know once that happens.\n\nThanks, and happy typing!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48652-retract-merge-offer/result.json b/src/_tests/fixtures/48652-retract-merge-offer/result.json index 83e848d07..426502a37 100644 --- a/src/_tests/fixtures/48652-retract-merge-offer/result.json +++ b/src/_tests/fixtures/48652-retract-merge-offer/result.json @@ -15,7 +15,7 @@ "status": "@mgol One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48708/result.json b/src/_tests/fixtures/48708/result.json index dafd58f19..b142798c5 100644 --- a/src/_tests/fixtures/48708/result.json +++ b/src/_tests/fixtures/48708/result.json @@ -21,7 +21,7 @@ "status": "@martin-badin I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed in a week if the issues aren't addressed." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48945/result.json b/src/_tests/fixtures/48945/result.json index cbc4d3fed..af4ed1fa1 100644 --- a/src/_tests/fixtures/48945/result.json +++ b/src/_tests/fixtures/48945/result.json @@ -15,7 +15,7 @@ "status": "@google-api-typings-generator One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/49417/result.json b/src/_tests/fixtures/49417/result.json index 449eb20e4..8c0204c24 100644 --- a/src/_tests/fixtures/49417/result.json +++ b/src/_tests/fixtures/49417/result.json @@ -20,7 +20,7 @@ "status": "@tuuling Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/49548/result.json b/src/_tests/fixtures/49548/result.json index 90db16aaf..bf6d41c96 100644 --- a/src/_tests/fixtures/49548/result.json +++ b/src/_tests/fixtures/49548/result.json @@ -20,7 +20,7 @@ "status": "Re-ping «anyone?»:\n\nThis PR has been out for over a week, yet I haven't seen any reviews.\n\nCould someone please give it some attention? Thanks!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/49639/derived.json b/src/_tests/fixtures/49639/derived.json index 837a3950b..5d365c5ee 100644 --- a/src/_tests/fixtures/49639/derived.json +++ b/src/_tests/fixtures/49639/derived.json @@ -23,21 +23,19 @@ { "path": "types/jasmine/tsconfig.json", "kind": "package-meta", - "suspect": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson) and not moving towards it", - "suggestion": { + "suspect": { "startLine": 21, "endLine": 21, - "text": " \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson) and not moving towards it\n```suggestion\n \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n```" } }, { "path": "types/jasmine/tslint.json", "kind": "package-meta", - "suspect": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#linter-tslintjson) and not moving towards it", - "suggestion": { + "suspect": { "startLine": 4, "endLine": 4, - "text": "" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#linter-tslintjson) and not moving towards it\n```suggestion\n```" } } ], diff --git a/src/_tests/fixtures/49639/mutations.json b/src/_tests/fixtures/49639/mutations.json index b0c93cb26..0ff7e3e03 100644 --- a/src/_tests/fixtures/49639/mutations.json +++ b/src/_tests/fixtures/49639/mutations.json @@ -45,7 +45,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDcyOTI0NjE3Mw==", - "body": "@ienzam Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jasmine` [on npm](https://www.npmjs.com/package/jasmine), [on unpkg](https://unpkg.com/browse/jasmine@latest/) (author is owner)\n - owner-approval: @chivesrs\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`jasmine/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-522bbd567aec6bfd3e2cd29af157310bd47eb79dbe6a670beb4da4e1a14d0f2d): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson) and not moving towards it\n - [`jasmine/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-0a3e03c56e43fc53245f1e4296782b62788ba4c9e70c9439d22b1998e681f55e): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#linter-tslintjson) and not moving towards it\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 8 days.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@ienzam Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jasmine` [on npm](https://www.npmjs.com/package/jasmine), [on unpkg](https://unpkg.com/browse/jasmine@latest/) (author is owner)\n - owner-approval: @chivesrs\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`jasmine/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-522bbd567aec6bfd3e2cd29af157310bd47eb79dbe6a670beb4da4e1a14d0f2d), [`jasmine/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-0a3e03c56e43fc53245f1e4296782b62788ba4c9e70c9439d22b1998e681f55e))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 8 days.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -56,7 +56,7 @@ "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NTIyNzM5MjUx", "path": "types/jasmine/tsconfig.json", "line": 21, - "body": "```suggestion\n \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n```" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson) and not moving towards it\n```suggestion\n \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n```" } } }, @@ -67,7 +67,7 @@ "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NTIyNzM5MjUx", "path": "types/jasmine/tslint.json", "line": 4, - "body": "```suggestion\n```" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#linter-tslintjson) and not moving towards it\n```suggestion\n```" } } }, diff --git a/src/_tests/fixtures/49639/result.json b/src/_tests/fixtures/49639/result.json index 31cdb76fb..b8f8e9cc5 100644 --- a/src/_tests/fixtures/49639/result.json +++ b/src/_tests/fixtures/49639/result.json @@ -16,21 +16,21 @@ }, { "tag": "welcome", - "status": "@ienzam Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jasmine` [on npm](https://www.npmjs.com/package/jasmine), [on unpkg](https://unpkg.com/browse/jasmine@latest/) (author is owner)\n - owner-approval: @chivesrs\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`jasmine/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-522bbd567aec6bfd3e2cd29af157310bd47eb79dbe6a670beb4da4e1a14d0f2d): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson) and not moving towards it\n - [`jasmine/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-0a3e03c56e43fc53245f1e4296782b62788ba4c9e70c9439d22b1998e681f55e): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#linter-tslintjson) and not moving towards it\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 8 days.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@ienzam Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jasmine` [on npm](https://www.npmjs.com/package/jasmine), [on unpkg](https://unpkg.com/browse/jasmine@latest/) (author is owner)\n - owner-approval: @chivesrs\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`jasmine/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-522bbd567aec6bfd3e2cd29af157310bd47eb79dbe6a670beb4da4e1a14d0f2d), [`jasmine/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-0a3e03c56e43fc53245f1e4296782b62788ba4c9e70c9439d22b1998e681f55e))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 8 days.\n\n----------------------\n... diagnostics scrubbed ..." } ], - "suggestions": [ + "explanations": [ { "path": "types/jasmine/tsconfig.json", "startLine": 21, "endLine": 21, - "text": " \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson) and not moving towards it\n```suggestion\n \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n```" }, { "path": "types/jasmine/tslint.json", "startLine": 4, "endLine": 4, - "text": "" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#linter-tslintjson) and not moving towards it\n```suggestion\n```" } ], "shouldClose": false, diff --git a/src/_tests/fixtures/49841/derived.json b/src/_tests/fixtures/49841/derived.json index fbb7665bf..b02b41862 100644 --- a/src/_tests/fixtures/49841/derived.json +++ b/src/_tests/fixtures/49841/derived.json @@ -27,11 +27,10 @@ { "path": "types/react-native-sha1/tsconfig.json", "kind": "package-meta", - "suspect": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson)", - "suggestion": { + "suspect": { "startLine": 17, "endLine": 17, - "text": "" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson)\n```suggestion\n```" } }, { diff --git a/src/_tests/fixtures/49841/mutations.json b/src/_tests/fixtures/49841/mutations.json index 747d1fcaa..c3ad54e57 100644 --- a/src/_tests/fixtures/49841/mutations.json +++ b/src/_tests/fixtures/49841/mutations.json @@ -65,7 +65,7 @@ "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NTI4OTE2Mjg5", "path": "types/react-native-sha1/tsconfig.json", "line": 17, - "body": "```suggestion\n```" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson)\n```suggestion\n```" } } }, diff --git a/src/_tests/fixtures/49841/result.json b/src/_tests/fixtures/49841/result.json index c8b4953a0..4d62158c8 100644 --- a/src/_tests/fixtures/49841/result.json +++ b/src/_tests/fixtures/49841/result.json @@ -19,12 +19,12 @@ "status": "@shekari-ah The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/4849e8876b0ab7adc889ccc35b55fde6f0274837/checks?check_suite_id=1574877739).\r\n\r\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!" } ], - "suggestions": [ + "explanations": [ { "path": "types/react-native-sha1/tsconfig.json", "startLine": 17, "endLine": 17, - "text": "" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson)\n```suggestion\n```" } ], "shouldClose": false,