Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: the setTitle function removes text style of the buttons on iOS12 #26

Open
lauthieb opened this issue Jan 21, 2022 · 1 comment
Open

bug: the setTitle function removes text style of the buttons on iOS12 #26

lauthieb opened this issue Jan 21, 2022 · 1 comment
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community

Comments

@lauthieb
Copy link
Member

Describe the bug

When using the setTitle function which is override on Vitamin:

public override func setTitle(_ title: String?, for state: UIControl.State) {
    super.setTitle(title, for: state)
    applyNewTextStyle()
}

The textstyle on the button is no longer applied on iOS 12
@lauthieb lauthieb added the bug 🐛 Something isn't working label Jan 21, 2022
@florentlotthepro florentlotthepro moved this from 🆕 New to 🔖 Dev to do in Decathlon Design System Dec 8, 2022
@daniel-dumortier
Copy link
Contributor

it could be worth checking if #102 has fixed this issue

@lauthieb lauthieb removed the run 💨 label Apr 7, 2023
@lauthieb lauthieb added the community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community
Projects
Decathlon Design System
Status: 🔖 Dev to do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lauthieb @daniel-dumortier