Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support LocalizedStringKey with TextField #130

Open
GerardPaligot opened this issue Mar 14, 2023 · 0 comments
Open

feat: Support LocalizedStringKey with TextField #130

GerardPaligot opened this issue Mar 14, 2023 · 0 comments
Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request

Comments

@GerardPaligot
Copy link

Is your request related to a problem? Please describe.

Describe the solution you'd like

For now, when I would like to use vitaminTextFieldStyle or directly the Vitamin component, I can only pass a String for the label and helperText.

    public func vitaminTextFieldStyle(
        style: VitaminTextFieldStyle = .outlined,
        label: String,
        helperText: String? = nil,
        state: Binding<VitaminTextFieldState>,
        icon: VitaminTextField.IconConfiguration? = nil,
        characterLimit: VitaminTextField.CharacterLimitConfiguration? = nil
    )

We should add variant to support LocalizedStringKey in addition to the existing API.

    public func vitaminTextFieldStyle(
        style: VitaminTextFieldStyle = .outlined,
        label: LocalizedStringKey,
        helperText: LocalizedStringKey? = nil,
        state: Binding<VitaminTextFieldState>,
        icon: VitaminTextField.IconConfiguration? = nil,
        characterLimit: VitaminTextField.CharacterLimitConfiguration? = nil
    )
@GerardPaligot GerardPaligot added the enhancement 🚀 New feature or request label Mar 14, 2023
@lauthieb lauthieb added run 💨 help wanted ✋ Extra attention is needed community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community and removed help wanted ✋ Extra attention is needed labels Mar 20, 2023
@lauthieb lauthieb removed the run 💨 label Apr 7, 2023
@lauthieb lauthieb moved this from 🆕 New to 🔖 Dev to do in Decathlon Design System Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request
Projects
Status: 🔖 Dev to do
Development

No branches or pull requests

2 participants