Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reports] Audit and Unify dataFormat behavior for Vizes #1323

Open
jhmullen opened this issue Dec 16, 2021 · 0 comments
Open

[reports] Audit and Unify dataFormat behavior for Vizes #1323

jhmullen opened this issue Dec 16, 2021 · 0 comments

Comments

@jhmullen
Copy link
Collaborator

jhmullen commented Dec 16, 2021

Between Viz.jsx, Options.jsx, and a handful of custom vizes for the CMS (Table.jsx), there is a janky dataFormat problem that I would love for @greenrhyno to sort out and unify.

The origin of the situation was, among other complexities, @palamago's implementation of datawheel cart. Further, vizes are meant to be able to handle a number of situations for the data key:

  • A straight up array of actual data, directly provided.
  • A single string, pointing to a url, to use its payload.
  • An array OF string urls, which are Promise.all'd and returned.
  • I think, some combination of direct data AND urls (?)

This is implemented in several locations, between d3 dataLoad, dataFormat, and searching for the word hasMultiples.

Sorting this out has been a quagmire for me, and I would love for this to be smoothed out, readable, and unified.

I'd like to backport any changes to canon-cms as well (see #1214)

@jhmullen jhmullen added this to the CMS 1.0 milestone Dec 16, 2021
@jhmullen jhmullen changed the title [reports] Audit and Unify dataFormat behavior for Vizes Audit and Unify dataFormat behavior for Vizes Dec 16, 2021
@jhmullen jhmullen changed the title Audit and Unify dataFormat behavior for Vizes [reports] Audit and Unify dataFormat behavior for Vizes Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants