Skip to content

Conversation

@Mathew-Estafanous
Copy link
Contributor

@Mathew-Estafanous Mathew-Estafanous commented Jan 23, 2026

What this PR does / why we need it:

  1. Exposes securityContext and annotations as configurable values in the CSI Driver.
  2. Adds baseline tests to validate proper formatting of rendered helm charts.

Which issue this PR fixes

The Datadog CSI Driver has limited configuration options and we'd like to expose important security related configuration options for customers deploying the CSI Driver.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • All commits are signed (see: signing commits)
  • Chart Version semver bump label has been added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@Mathew-Estafanous Mathew-Estafanous requested review from a team as code owners January 23, 2026 18:37
@Mathew-Estafanous Mathew-Estafanous self-assigned this Jan 23, 2026
@Mathew-Estafanous Mathew-Estafanous added the datadog-csi-driver/minor-version Minor version bump for datadog-csi-driver chart label Jan 23, 2026
dd-octo-sts bot and others added 6 commits January 23, 2026 19:18
- bump version for datadog-csi-driver to 0.5.0 (minor-version)
- update changelog for datadog-csi-driver with version 0.5.0
- update readme for datadog-csi-driver
- update readme for datadog-csi-driver
- update readme for datadog-csi-driver
)

const (
SkipTest = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify what the purpose of this SkipTest constant is?

I see that the Operator unit tests have it but I also don't understand the purpose of it there:

const (
SkipTest = false
)
func Test_operator_chart(t *testing.T) {
tests := []struct {
name string
command common.HelmCommand
assertions func(t *testing.T, manifest string)
skipTest bool
}{
{
The other unit tests for regular helm chart don't have this const.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason besides copying it from the operator tests. I'll remove it.

Copy link
Contributor

@gabedos gabedos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exposing the additional configuration options as well as implementing the unit tests for the datadog-csi-driver helm chart looks good to me!

@Mathew-Estafanous
Copy link
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 23, 2026

View all feedbacks in Devflow UI.

2026-01-23 20:28:43 UTC ℹ️ Start processing command /merge


2026-01-23 20:28:52 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 50m (p90).


2026-01-23 20:53:46 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 2c84698 into main Jan 23, 2026
50 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the mathew.estafanous/csidriver-add-values branch January 23, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

datadog-csi-driver/minor-version Minor version bump for datadog-csi-driver chart mergequeue-status: done tools/ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants