-
Notifications
You must be signed in to change notification settings - Fork 1k
[CONTP-719] Expose security context and annotation configurations #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONTP-719] Expose security context and annotation configurations #2317
Conversation
- bump version for datadog-csi-driver to 0.5.0 (minor-version) - update changelog for datadog-csi-driver with version 0.5.0 - update readme for datadog-csi-driver
- update readme for datadog-csi-driver
- update readme for datadog-csi-driver
| ) | ||
|
|
||
| const ( | ||
| SkipTest = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify what the purpose of this SkipTest constant is?
I see that the Operator unit tests have it but I also don't understand the purpose of it there:
helm-charts/test/datadog-operator/operator_deployment_test.go
Lines 23 to 35 in c523cc5
| const ( | |
| SkipTest = false | |
| ) | |
| func Test_operator_chart(t *testing.T) { | |
| tests := []struct { | |
| name string | |
| command common.HelmCommand | |
| assertions func(t *testing.T, manifest string) | |
| skipTest bool | |
| }{ | |
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular reason besides copying it from the operator tests. I'll remove it.
gabedos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposing the additional configuration options as well as implementing the unit tests for the datadog-csi-driver helm chart looks good to me!
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What this PR does / why we need it:
securityContextandannotationsas configurable values in the CSI Driver.Which issue this PR fixes
The Datadog CSI Driver has limited configuration options and we'd like to expose important security related configuration options for customers deploying the CSI Driver.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)GitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md