-
Notifications
You must be signed in to change notification settings - Fork 1k
Add injectionMode option for APM instrumentation #2308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Mathew-Estafanous
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good.
One ask. Can you add a check in NOTES.txt that warns or errors when datadog.apm.instrumentation.injectMode is set to csi without datadog.csi.enabled set to true?
I think that should prevent customers attempting to use CSI injection without first setting up the driver itself.
| }, | ||
| "injectionMode": { | ||
| "type": "string", | ||
| "enum": ["auto", "init_container", "csi"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
8bfa71e to
f610a00
Compare
f610a00 to
6a557f4
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
You are not allowed to use the merge queue towards |
What this PR does / why we need it:
This PR adds a new
datadog.apm.instrumentation.injectionModeoption to configure how tracing libraries are injected into application pods.Supported modes:
auto(default): Automatically selects the best injection methodinit_container: Uses init containers to inject librariescsi: Uses the Datadog CSI Driver to inject libraries (experimental)The CSI injection mode is experimental and requires Cluster Agent 7.76.0+ with the Datadog CSI Driver installed.
Changes:
injectionModeoption invalues.yamlwith default value"auto"DD_APM_INSTRUMENTATION_INJECTION_MODEenv var to Cluster Agent when setvalues.schema.jsonwith the new field and allowed valuesRelated PRs:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)GitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md