Skip to content

obs-pipelines: clarify instructions to configure secrets management #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Jan 21, 2026
Merged

obs-pipelines: clarify instructions to configure secrets management #2307

gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Jan 21, 2026

Conversation

@jackie8c
Copy link
Contributor

@jackie8c jackie8c commented Jan 16, 2026 •
edited
Loading

What this PR does / why we need it:

Add clarifying note on secrets management.

Original PR.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • All commits are signed (see: signing commits)
  • Chart Version semver bump label has been added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@github-actions github-actions bot added the chart/observability-pipelines-worker This issue or pull request is related to the observability-pipelines-worker chart label Jan 16, 2026
@jackie8c Graphite App
Copy link
Contributor Author

jackie8c commented Jan 16, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jackie8c jackie8c force-pushed the jacqueline.chin/secrets-management-clarification branch from 3131f99 to d6762f5 Compare January 16, 2026 22:04
@jackie8c jackie8c marked this pull request as ready for review January 16, 2026 22:04
@jackie8c jackie8c requested a review from a team as a code owner January 16, 2026 22:04
@jackie8c jackie8c changed the title Clarify instructions to configure secrets management obs-pipelines: clarify instructions to configure secrets management Jan 16, 2026
@jackie8c jackie8c force-pushed the jacqueline.chin/secrets-management-clarification branch 2 times, most recently from bafea90 to 5d7aefa Compare January 20, 2026 14:21
@jackie8c
Copy link
Contributor Author

jackie8c commented Jan 20, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 20, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-20 22:00:52 UTC ℹ️ Start processing command /merge

2026-01-20 22:01:00 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 50m (p90).

2026-01-20 22:05:05 UTC 🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:

  • target branch of PR is restricted to only allow up-to-date branches, but the pr is now outdated
Details

Error: PUT https://api.github.com/repos/DataDog/helm-charts/pulls/2307/merge: 405 Required status check "pr-validated" is expected. [] (Request ID: BF4A:3D38E2:2388D8C:9B0A070:696FFC08)

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 52, startedEventID: 53, identity: 1@github-worker-79b656778c-7rvdz@): PUT https://api.github.com/repos/DataDog/helm-charts/pulls/2307/merge: 405 Required status check "pr-validated" is expected. [] (Request ID: BF4A:3D38E2:2388D8C:9B0A070:696FFC08) (type: GitFailure, retryable: false): PUT https://api.github.com/repos/DataDog/helm-charts/pulls/2307/merge: 405 Required status check "pr-validated" is expected. [] (type: ErrorResponse, retryable: true)

@jackie8c jackie8c force-pushed the jacqueline.chin/secrets-management-clarification branch from 5d7aefa to 9512787 Compare January 20, 2026 22:07
@jackie8c
Copy link
Contributor Author

jackie8c commented Jan 21, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 21, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-21 13:57:40 UTC ℹ️ Start processing command /merge

2026-01-21 13:57:49 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 50m (p90).

2026-01-21 14:00:47 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 6ccff83 into main Jan 21, 2026
35 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the jacqueline.chin/secrets-management-clarification branch January 21, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilychendd emilychendd emilychendd approved these changes

Assignees

No one assigned

Labels

chart/observability-pipelines-worker This issue or pull request is related to the observability-pipelines-worker chart mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackie8c @emilychendd