Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to Disable Storing Cache Keys in Span Traces #4017

Open
n-ikhil opened this issue Oct 21, 2024 · 6 comments
Open

Option to Disable Storing Cache Keys in Span Traces #4017

n-ikhil opened this issue Oct 21, 2024 · 6 comments
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations

Comments

@n-ikhil
Copy link

n-ikhil commented Oct 21, 2024

In our Rails application, we've observed that cache keys are being recorded and displayed in span traces within the Datadog UI. This behavior raises potential security and privacy concerns, as cache keys may contain sensitive or identifiable data. Additionally, showing the cache keys in the UI can clutter trace details, making it harder to focus on high-level performance insights.

We would like to request a feature that allows users to disable the storage of cache keys in span traces, either by:

  1. Configuration option: Introduce a flag to enable/disable the recording of cache keys.
  2. Redaction: Provide an option to redact or anonymize cache keys before they are displayed.
@n-ikhil n-ikhil added community Was opened by a community member feature-request A request for a new feature or change to an existing one labels Oct 21, 2024
@delner
Copy link
Contributor

delner commented Oct 22, 2024

Thanks for raising this! I assume this is for ActiveSupport? Or for a different framework/client?

I will forward this to our team, see what they think of it. We do provide similar capabilities to quantize other fields such as HTTP headers and what not, so its not unprecedented.

@delner delner added the integrations Involves tracing integrations label Oct 22, 2024
@n-ikhil
Copy link
Author

n-ikhil commented Oct 22, 2024

Yes @delner this is for ActiveSupport integration.

@delner
Copy link
Contributor

delner commented Oct 24, 2024

Hi @n-ikhil , just wanted to update you: we've opened #4022 to add the capability to disable the collection of cache keys. The PR does not include any kind of redaction option yet.

@n-ikhil
Copy link
Author

n-ikhil commented Nov 21, 2024

@delner any update with the pr/rollout ?

@bouwkast
Copy link
Contributor

Thanks @n-ikhil, I've updated that PR to include an option for the time being to disable adding the cache_key as a span tag.

@bouwkast
Copy link
Contributor

@n-ikhil #4022 has been merged and should be out in the next release (2.9.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations
Projects
None yet
Development

No branches or pull requests

3 participants