HTTP 4xx errors are treated as errors

[d33kayyy]

Hi, I recently upgraded my Python application from Python 3.10 to 3.12, hence I had to upgrade ddtrace from 1.20.19 to 2.16.1.

I noticed that now responses with HTTP 4xx are also considered as errors. I checked the documentation and found DD_TRACE_HTTP_SERVER_ERROR_STATUSES. However, I'm not setting it in my project that it should use the default, which must be status between 500-599.

Libraries' versions

django==5.1.3
ddtrace==2.16.1
gunicorn==20.1.0
uvicorn==0.32.0

Running with

ddtrace-run gunicorn -w $HTTP_WORKER_COUNT -k example.asgi.UvicornWorker --bind 0.0.0.0:$PORT example.asgi:application

[wantsui]

@d33kayyy In your screenshot, is that issue occurring with the span name/operation name django.request? Or are you seeing it on a different span?

[d33kayyy]

@wantsui yes it is operation:django.request

[wantsui]

@d33kayyy Thanks for confirming!

Unfortunately, I wasn't able to reproduce this with 2.16.1 with the details that you provided (see my attempt under What I tried). My 404s are correctly marked as "OK" by default.

I can think of a few things that could differentiate your application from my attempt, like:

• having special middleware or logic for handling statuses in your Django application, ie: https://docs.djangoproject.com/en/5.1/topics/http/middleware/#exception-handling
• DD_TRACE_HTTP_SERVER_ERROR_STATUSES is being set somewhere in the environment
• some kind of internal exception did occur but the Django application was told to return a 4xx?

Is there anything in your application that might be doing anything like that?

Note: In case there are details about the application that you may not want to write out in a public thread, you can also open a support ticket with us through any of these options listed here: https://docs.datadoghq.com/help/ . If you reference this Github issue, the support engineer will be able to associate this Github issue with the support ticket and we can keep troubleshooting from there too.

What I tried
I tried reproducing this with the versions listed and a basic application configured with Django ie: (https://docs.djangoproject.com/en/5.1/intro/tutorial01/), running over gunicorn, ie: ddtrace-run gunicorn helloworld.wsgi --bind 0.0.0.0 .

When I send a request to an endpoint that doesn't exist, my 404 request correctly shows up under the OK status, ie:

And in debug mode, I can see that the error is marked as 0 (for an "OK" status)

finishing span name='django.request' id= trace_id= parent_id=None service='djangoapp' resource='GET 404' type='web' start= end= duration=0.005796417 error=0