Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CosmosDB autoinstumentation of addtional container methods #5294

Open
bjongbloedt opened this issue Mar 8, 2024 · 0 comments
Open

CosmosDB autoinstumentation of addtional container methods #5294

bjongbloedt opened this issue Mar 8, 2024 · 0 comments

Comments

@bjongbloedt
Copy link

Are you requesting automatic instrumentation for a framework or library? Please describe.

It looks like parts of the Microsoft.Azure.Cosmos library were instrumented (mostly on the query end), but I am doing a lot of other operations that I would like included in my traces.

  • Framework or library name : Microsoft.Azure.Cosmos
  • Library type: Database
  • Library version: 3.37.1

Is your feature request related to a problem? Please describe.

It seems like a good chunk of cosmos operations are missing from the instrumentation.

Ideally I would like to see the spans for a handful of point operations on my cosmos container. For my use case its DeleteItemAsync, ReadItemAsync, and UpsertItemAsync, but I have other projects coming up that are also using the patch operations and other cosmosdb operations.

Describe the solution you'd like

Essentially a furthering of this PR for a subset of ContainerCore.Items.cs set of actions.

Describe alternatives you've considered

  • I have thought about bringing in the Datadog.Trace nuget library directly (or the annotation library) and hand annotating the calls to cosmos, but I know that starts to muck with the automated instrumentation and can cause versioning issues.

Additional context

  • I see this initial pull request to add support for the query methods. I am guessing that the other methods could be added in this same fashion, but I don't know the codebase very well
  • I am running my current setup in a debian container on container apps, so that may be causing some issues since I see a few notes around about how this was tested on windows
  • I am integrating in cosmosDB to an aspnetcore mvc project with datadog's automated instrumentation setup like this. It seems like other operation types are coming through fine, but the methods mentioned above are not showing up under a cosmosdb operation tag, though they are being executed

Please let me know if I have read the code wrong or it should be working and I have another issue in my configuration I have to hunt down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant