Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associating attributes with WebView RUM #1104

Closed
kabiroberai opened this issue Dec 23, 2022 · 2 comments
Closed

Associating attributes with WebView RUM #1104

kabiroberai opened this issue Dec 23, 2022 · 2 comments
Assignees

Comments

@kabiroberai
Copy link

At the moment, RUM events sent through the Web View bridge (i.e. web views configured with WKUserContentController.trackDatadogEvents) don't include attributes defined via Global.rum.addAttribute. This is somewhere in between a bug report and a feature request but it'd be great if the iOS RUM attributes could be combined with the browser RUM attributes. Without this in place, Datadog appears to non-deterministically(!) nuke iOS attributes from app sessions because it looks to be using a heuristic (last/most frequent view?) to determine which set of view attributes it should apply to the session as a whole.

I'm currently getting around this with a hacky redefinition of window.DatadogEventBridge.send but I have a feeling an in-tree fix could be a lot cleaner, by merging the browser and iOS attributes in DefaultWebRUMEventConsumer.map(event:with:).

@maciejburda
Copy link
Member

Thanks for reporting this @kabiroberai. I will double check with the team and get back to you as soon as I can.

@mariedm
Copy link
Member

mariedm commented Jan 10, 2025

Hello 👋

I'm closing this issue due to inactivity. For the record, you are correct that iOS global RUM attributes are not currently injected into browser events, and we have no plans to change this behavior at this time. Thank you for bringing this to our attention though.

Feel free to reopen the issue if you have more questions or need additional clarification on this topic.

@mariedm mariedm closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants