Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for datadog gem, instead of deprecated ddtrace gem #91

Open
tylerjc opened this issue Jul 12, 2024 · 5 comments
Open

Support for datadog gem, instead of deprecated ddtrace gem #91

tylerjc opened this issue Jul 12, 2024 · 5 comments
Assignees

Comments

@tylerjc
Copy link

tylerjc commented Jul 12, 2024

Good afternoon all!

We're attempting to get our AWS Lambdas instrumented for the first time (with a container image using the guide found here).

I had originally added the two gems it calls out in that guide, but when running bundle install there was a note from datadog that the ddtrace gem is out (or on its way out), and the new thing to use is the datadog gem. Except that doesn't appear to be compatible with the datadog-lambda gem from the looks of testing things out after deploying (stacktrace snippet pasted below).

Is this known/expected with plans to add support for switching to datadog? Or am I missing a piece where it already is possible to use that gem instead of ddtrace?

Any help would be great, thanks!

Specifications

  • Datadog Lambda Layer Extension version: public.ecr.aws/datadog/lambda-extension:latest
  • Ruby version: 3.2.2

Stacktrace

2024-07-12T15:29:17.912-05:00	Error raised from handler method
2024-07-12T15:29:17.912-05:00	{
2024-07-12T15:29:17.912-05:00	"errorMessage": "unknown keyword: :span_type",
2024-07-12T15:29:17.912-05:00	"errorType": "Function<ArgumentError>",
2024-07-12T15:29:17.912-05:00	"stackTrace": [
2024-07-12T15:29:17.912-05:00	"/layers/paketo-buildpacks_bundle-install/launch-gems/ruby/3.2.0/gems/datadog-2.2.0/lib/datadog/tracing.rb:17:in `trace'",
2024-07-12T15:29:17.912-05:00	"/layers/paketo-buildpacks_bundle-install/launch-gems/ruby/3.2.0/gems/datadog-lambda-2.22.0/lib/datadog/lambda/trace/listener.rb:51:in `on_start'",
2024-07-12T15:29:17.912-05:00	"/layers/paketo-buildpacks_bundle-install/launch-gems/ruby/3.2.0/gems/datadog-lambda-2.22.0/lib/datadog/lambda.rb:64:in `wrap'",
2024-07-12T15:29:17.912-05:00	"/workspace/lambdas/transmitter.rb:13:in `process'",
@kwent
Copy link

kwent commented Sep 10, 2024

@DataDog Please update

@hghotra hghotra self-assigned this Sep 12, 2024
@duncanista
Copy link
Contributor

duncanista commented Sep 16, 2024

Hey sorry,

We are working on upgrading this soon.
First we'll support 3.3, then upgrade the gem on another release!

Sorry for the inconvenience, we haven't had enough bandwidth to support this, but we are now actively working on it.

Any open-source contributions are highly encouraged!

@duncanista
Copy link
Contributor

duncanista commented Nov 6, 2024

Hey team, sorry I haven't responded on this issue, I've been quite busy working on a product release. Will try to allocate someone in this project as soon as possible

@amancevice amancevice mentioned this issue Nov 6, 2024
10 tasks
@duncanista
Copy link
Contributor

Working actively on this, added #99 to address some issues

@duncanista
Copy link
Contributor

Still working on it, as it's not fully compatible with the new extension for some reason, need to figure out what might be the issue there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants