-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General filter chit-chat №2 #63
Comments
How are we expected to resolve any issues, with such a low limit!? :) |
Ad labels between feed entries: Possible fix: |
@THEtomaso Just a personal opinion about the matter you noted in the previous thread. Using social filter does not necessarily mean you wanna block anything social. I don't use Facebook and I subscribe AdGuard Social, but hope any of my filters never ever interfere with news article about Facebook which may or may not include links to FB, which unfortunately for me was the case for Fanboy Social - I don't report such one-time false positives but still they're annoying. I rather wonder why so many filters, not limited to social ones, prefer generic rules and don't make specific rules one-by-one - this way you can avoid most of false positives, and I believe it's more efficient in terms of performance unless the number of rules goes too many. I don't expect any filter to be perfect on blocking and kinda accept some false negatives, but single false positive is annoying enough despite I can fix them. I maintain my own private filters which currently include about 2,000 rules each for PC & mobile, most of them are specific rules and I make a rule generic only after I confirmed the pattern is found on many sites (usually 3-5+ sites). AdGuard also tends to use more specific rules compared to EasyList/Fanboy and even replaced some generic rules in EL with specific rules, which I think makes sense given most AG users are noobs. Well, one thing I'm not so happy is AG filters tend to rely too much on cosmetic filters which I don't see much value. |
Getting close to 19.000 rules in my own filter, and particularly the social media entries (site-specific ones) has gotten way out of hand! |
Possible fix:
|
The crap remains!: |
I missed out on the |
Also, you missed the ad label in my last screenshot! EDIT: |
|
(To THEtomaso) The ad label is removed by I'll add an entry for the (To krystian3w) Presuming this was meant for the Anti-'Custom cursors' List, I thank you greatly for that tip. I'll add an entry for it pretty soon. |
No need. |
I suppose it does, now that I tested them out... Give me some seconds. |
It may be time for you to build your empire ;) I'm speaking on users' side, particularly when it comes to social staff false negatives are not big deal. I basically ignore those social buttons unless either I can block them all by 1 or 2 blocking rules alone (no cosmetic rule), or they're annoying enough (e.g. floating buttons), but one FP is worse than 20 FNs at least for me - maybe it's only me. Having looked various filters, I see one tendency that newer filter maintainers tend to use more specific rules. I guess that's reasonable from the current user base perspective. Also If one generic rule replaced 5 specific rules but required 4 exception rules to be added, it doesn't make much sense. |
I for one felt I had to create my own social list that solely removed sharing buttons, as I felt that both AdGuard's and Fanboy's social lists were far too broadly blocking. And sadly, social media stuff is very difficult to handle with adblock lists. Even though I use very broad hiding rules in that list, around ¼ of all websites I come across still slip through it. |
Deblurrer for Example: |
PSA (although not a critical one): If you ever see any filterlists use From what I could understand from https://translate.google.com/translate?sl=auto&tl=en&u=https%3A%2F%2Fwww.huorong.cn%2Finfo%2F1582284212427.html, the ChinaList 2.0 list was caught red-handed trying to earn affiliation rewards from extension users, and has now been emptied as a result of sheer shame. |
Are you aware of any list that actually uses that strange modifier? |
My personal but unclear understanding is that ChinaList 2.0 (Here's a Wayback Machine entry that includes the entries) was the only list to ever have used it, thankfully. But although I look through many lists frequently as a hobby, who knows if there's something else out there that has or will manage to slide by behind our backs. |
Only modified uBO / AG / AdBlock (or ABP)? |
I think I will use Dead-Hosts so other people do it for me since I'm not a developer to use |
https://github.com/FiltersHeroes/ScriptsPlayground/blob/master/scripts/ECODFF.sh But I can't help much on the errors that GNU/Linux or WSL 2 will spit out. |
PyFunceble shouldn't require docker (at least on Windows, I haven't tried it on Linux but it should work). It should just install via pip if you have Python installed.
Cool script, thanks. |
I am not a developer, so I don't have Python installed either. |
If you are not on Windows 7 or legacy GNU/Linux distro then installation is "easy". On Windows 7 needed is use Python embeded into LibreOffice/Gimp or unofficial installers like: https://github.com/adang1345/PythonWin7 Or you use account with limitation on corporation/company PC? |
How do I use that?
I am on Windows 10 Pro version 22H2.
No. I'm using my home PC. |
And what about this: https://github.com/uBlockOrigin/uAssets/tree/master/tools/validate. |
Remarkably enough yes. ABP removed the need to use
I know that while PyFunceble is designed for Linux, I've got it to run natively in both Cygwin and PowerShell (albeit with a performance hit in the latter).
I know of at least a few end-user tools that require Python and some knowledge of command lines (e.g. the
Indeed I've experienced that W10 onwards handle command line stuff much better than earlier versions, e.g. stuff like SSH connections.
Seems like it's in need of installation instructions for end-users. |
With Chromium 105+ simple filters with FiltersHeroes/PolishAnnoyanceFilters@0f251f2 - example where CSS4 works fine on ABP with Chromium 105+ but |
But there are instructions already: |
Regarding |
The first time I heard that, have been using on Windows with conda. |
#63 (comment) - also needed add colon after list of pseudo-classes in uBo was limited to documented at mdn list. ! for ≈ uBo 1.46.1rc0+
mdn.mozilla.org##a::before:style(color: red !important; content: 🧷 !important;) Only IE6 - IE8 users on XP/Vista are affected (as anything JS based page will open there) [and sleeping projects]. AdGuard has now also started removing the old |
I'm not certain if I understood you right.. |
Good to know, though this would technically make it feasible to add a "Click on the
As far as I can determine from discussions about it: Yes. |
also needed add colon In short invalid with 1 colon even have |
Although still somewhat cryptic to me, I'll take that as a yes. |
Then someone will attach why these are only monosyllables and not Shakespearean sentences (phrases/paragraphs). |
@krystian3w Could you try writing in Polish then use FiltersHeroes/PolishAnnoyanceFilters#1723 (comment):
FiltersHeroes/PolishAnnoyanceFilters#3023 (comment):
FiltersHeroes/PolishAnnoyanceFilters#1614 (comment):
|
In the first case it was about a modal with a strange number in the "timeout" ( The second item turned out to be third-party advertising (not self-promo). In the third comment, I meant to ensure the time that uBo will be widely distributed in an improved version (so that the list gives the most benefits and spoils pages as little as possible). Powered by deepl instead Google - I am so sorry. |
IMO that's a lot more fluent and understandable. |
DeepL is so much better than Google Translate! Sadly, DeepL supports a really low number of languages. |
I use the both, and I agree, most of time time DeepL is better, however occasionally Google Translator is better in some cases and supports more languages, also I sometimes use another one: Reverso, but not so often thus I'm not sure about it translation skills compared to DeepL and GoogleTR, I must begin to use it more frequently, also - a future translator: Universal Tanslator & Universal Translator |
I have now after all decided to create #779 as a №3 on experimental basis after all. It may or may not receive major changes and overly loose/strict moderation in the future with little or no advance notice. I've also noticed that Though I was in fact able to understand #63 (comment), I did find #63 (comment) to have a nice flow to it, especially more consistent use of "a"/"the" which I know that even very language-skilled eastern Europeans have struggled with. Despite what DeepL's company claims, they're fairly slow to add new languages. They added Norwegian a mere 3 weeks ago, and likely can't do Nynorsk→English the way Google unofficially can. |
It's a known issue and it's being fixed. https://github.com/orgs/community/discussions/46691#discussioncomment-4953226 NEW General filter chit-chat: #779 |
(The option to close a thread simply didn't show up if the comment number was exactly 2,500, so I had to delete 1 comment at near-random: see #779 (comment) for details.) |
Note, 13th of February 2023: Next de facto discussion place until further notice is at #779.
————————————
So today I learned that GitHub threads max out at 2,500 comments, despite nothing and no one ever telling me about that previously, let alone GitHub's help pages. So here's thread number 2!
This thread is a megathread about adblock discussions in general. Here one can request syntax help, reproduction confirmations, info about differences between adblockers, assistance with making new lists, and so on. They'll be answered or considered by the biggest Adfilt contributors, and occasionally by members of the uBlock Origin development team (although in an unofficial fashion). (This header section was last updated on the 24th of April 2019 by DandelionSprout.)
Same non-obligatory rules apply as in the previous thread (Rules can be amended by Dandelion Sprout on very short notice, but this happens pretty rarely):
The text was updated successfully, but these errors were encountered: