Skip to content

Commit 70c2fbd

Browse files
author
stack
committed
Add support for testing with different resource types other than dummy nodes.
1 parent fbc12ec commit 70c2fbd

File tree

7 files changed

+25
-14
lines changed

7 files changed

+25
-14
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
clouds.yaml
2+
tests/functional/err*

tests/functional/setup.sh

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,16 @@ tmpfile="$1"
44
project_id="$2"
55
start="$3"
66
end="$4"
7+
resource_type="$5"
78
lessee_option=''
89
nodefile=$(mktemp /tmp/nodes/XXXX)
910
errfile=$(mktemp ./errXXXXXX)
1011
node_uuid=$(echo $nodefile | sed 's/\/tmp\/nodes\///')
1112

13+
if [[ -z "$5" ]]; then
14+
resource_type="dummy_node"
15+
fi
16+
1217
# Create dummy node
1318

1419
cat <<EOF > /tmp/nodes/$node_uuid
@@ -26,8 +31,8 @@ cat <<EOF > /tmp/nodes/$node_uuid
2631
EOF
2732

2833
# Check if the lessee was passed
29-
if ! [[ -z "$5" ]]; then
30-
lessee_option=" --lessee $5"
34+
if ! [[ -z "$6" ]]; then
35+
lessee_option=" --lessee $6"
3136
fi
3237

3338
#######################
@@ -42,7 +47,7 @@ openstack --os-cloud test1 esi offer create \
4247
$node_uuid \
4348
--start-time "$start" \
4449
--end-time "$end" \
45-
--resource-type dummy_node\
50+
--resource-type "$resource_type"\
4651
$lessee_option \
4752
-f shell > $tmpfile \
4853
|| { ec=$?; echo "ERROR: failed to create offer" >&2; exit $ec; }

tests/functional/test-lease-expire.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ project_id=75681640118a4890b3da0d106eae8af7 # test1 uuid
44
tmpfile=$(mktemp ./leaseXXXXXX)
55
start=$(date +%Y-%m-%d)
66
end=$(date -d "+5 days" +"%Y-%m-%d")
7+
resource_type="dummy_node"
78

89
# Setup script, contains offer create test
910

tests/functional/test-lessee-id.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@ project_id=75681640118a4890b3da0d106eae8af7 # test1 uuid
44
tmpfile=$(mktemp ./leaseXXXXXX)
55
start=$(date +%Y-%m-%d)
66
end=$(date -d "+5 days" +%Y-%m-%d)
7+
resource_type="dummy_node"
78
lessee='test1-subproject'
89

910
# Setup script, contains offer create test
1011

11-
./setup.sh "$tmpfile" "$project_id" "$start" "$end" "$lessee"
12+
./setup.sh "$tmpfile" "$project_id" "$start" "$end" "$resource_type" "$lessee"
1213

1314
# Sources variables defined in the setup script
1415
. $tmpfile
@@ -78,7 +79,7 @@ cat <<EOF
7879
Created lease $uuid:
7980
Starting at: $start_time
8081
Ending at: $end_time
81-
For: $resource_type $resource_uuid
82+
For: $resource_type ${nodefile##/tmp/nodes/}
8283
From offer: $test_offer_uuid
8384
EOF
8485

tests/functional/test-no-lessee-id.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@ project_id=75681640118a4890b3da0d106eae8af7 # test1 uuid
44
tmpfile=$(mktemp ./leaseXXXXXX)
55
start=$(date +%Y-%m-%d)
66
end=$(date -d "+5 days" +%Y-%m-%d)
7+
resource_type="dummy_node"
78

89
# Setup script, contains offer create test
910

10-
./setup.sh $tmpfile $project_id $start $end
11+
./setup.sh "$tmpfile" "$project_id" "$start" "$end" "$resource_type"
1112

1213
. $tmpfile
1314

@@ -28,10 +29,10 @@ openstack --os-cloud test1 esi offer create \
2829
$node_uuid \
2930
--start-time $start \
3031
--end-time $end \
31-
--resource-type dummy_node \
32+
--resource-type $resource_type \
3233
-f shell > $tmpfile 2> $errfile
3334
ec=$?
34-
expected_error="Time conflict for dummy_node $node_uuid."
35+
expected_error="Time conflict for $resource_type $node_uuid."
3536

3637
if ! cat $errfile | grep -q "$expected_error"; then
3738
if [[ $ec -eq 0 ]]; then

tests/functional/test-no-offer.sh

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ start=$(date +%Y-%m-%d)
66
end=$(date -d "+5 days" +%Y-%m-%d)
77
nodefile=$(mktemp /tmp/nodes/XXXX)
88
errfile=$(mktemp ./errXXXXXX)
9-
node_uuid=$(echo $nodefile | sed 's/\/tmp\/nodes\///')
9+
node_uuid=${nodefile##/tmp/nodes}
10+
resource_type="dummy_node"
1011

1112
trap "rm -f $nodefile $tmpfile $errfile" EXIT
1213

@@ -39,7 +40,7 @@ openstack --os-cloud test1 esi lease create \
3940
test1-subproject \
4041
--start-time $start \
4142
--end-time $end \
42-
--resource-type dummy_node \
43+
--resource-type $resource_type \
4344
-f shell > $tmpfile \
4445
|| { ec=$?; echo "ERROR: failed to create lease" >&2; exit $ec; }
4546

@@ -73,10 +74,10 @@ openstack --os-cloud test2 esi offer create \
7374
$node_uuid \
7475
--start-time $start \
7576
--end-time $end \
76-
--resource-type dummy_node \
77+
--resource-type $resource_type \
7778
-f shell > $tmpfile 2> $errfile
7879
ec=$?
79-
expected_error="Access was denied to dummy_node $node_uuid."
80+
expected_error="Access was denied to $resource_type $node_uuid."
8081

8182
if ! cat $errfile | grep -q "$expected_error"; then
8283
if [[ $ec -eq 0 ]]; then
@@ -106,10 +107,10 @@ openstack --os-cloud test2 esi lease create \
106107
test2-subproject \
107108
--start-time $start \
108109
--end-time $end \
109-
--resource-type dummy_node \
110+
--resource-type $resource_type \
110111
-f shell > $tmpfile 2> $errfile
111112
ec=$?
112-
expected_error="Access was denied to dummy_node $node_uuid."
113+
expected_error="Access was denied to $resource_type $node_uuid."
113114

114115
if ! cat $errfile | grep -q "$expected_error"; then
115116
if [[ $ec -eq 0 ]]; then

tests/functional/test-offer-expire.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ project_id=75681640118a4890b3da0d106eae8af7 # test1 uuid
44
tmpfile=$(mktemp ./leaseXXXXXX)
55
start=$(date +%Y-%m-%d)
66
end=$(date -d "+1 minute" +"%Y-%m-%d %H:%M:%S")
7+
resource_type="dummy_node"
78

89
# Setup script, contains offer create test
910

0 commit comments

Comments
 (0)