Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brackets in Server Name breaks future edit/delete #218

Open
nomisum opened this issue Feb 6, 2022 · 3 comments
Open

Brackets in Server Name breaks future edit/delete #218

nomisum opened this issue Feb 6, 2022 · 3 comments

Comments

@nomisum
Copy link

nomisum commented Feb 6, 2022

No description provided.

@Dahlgren
Copy link
Owner

Dahlgren commented Feb 7, 2022

Unable to repro. Are you running some outdated code or dependencies?

image

image

@nomisum
Copy link
Author

nomisum commented Feb 7, 2022

weird. now i cant repro either, wtf.

what else could prevent deletion of instances? i had them deleted manually in the meantime so cant dig deeper rn.

@Dahlgren
Copy link
Owner

Dahlgren commented Feb 7, 2022

Added tests for good measure, the behaviour for parentheses will be changed to be same as brackets,

it('should generate id for title with dots', function () {
Server.generateId('title.with.lot.of.dots').should.eql('title-with-lot-of-dots')
})
it('should generate id title with brackets', function () {
Server.generateId('title [with] [lots of] [brackets]').should.eql('title-with-lots-of-brackets')
})
it('should generate id title with parentheses', function () {
Server.generateId('title (with) (lots of) (parentheses)').should.eql('title-with-lots-of-parentheses')
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants