-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various modules requires backtrackerservice_dune.fcl. This fcl is in dunesw #2
Comments
This is really only an issue if the user does not build dunesw simultaneously with protodune -- in which they case they can just |
However it kind of goes against the idea of what a dependency is |
Yes, there are several fcl files like this: services_dune.fcl and tools_dune.fcl. There was refactoring of services configurations but I have not checked it. I think the line is that the DUNE software stack only is fully functional when you set it all up, even if you build only part of it. Otherwise, we must support a lot of independent software stacks. I had originally considered making a duneconfig product at the bottom of the tree. The problem I had with that is that some fcl files were in specific directories and the general fcl files like services_dune.fcl would #include fcl files in products above duneconfig. |
https://github.com/DUNE/dunecore/blob/34dc500a799db08fbced39fe769a0f6eb113f697/dunecore/Utilities/services_common_dune.fcl Should look through this and determine if files should be brought to dunecore |
I just now added backtrackerservice_dune.fcl to dunecore/Utilities and took it out of dunesw/fcl. |
Here's a listing of the ups products that each of the fcl files #included by dunecore/Utilities/services_common_dune.fcl are located in, as of release v09_42_00_01. dunecore geometry_dune.fcl |
I moved time_memory_tracker_dune.fcl and particleinventoryservice_dune.fcl to dunecore. There are some issues with the ones in dunesim and duneopdet. One solution so that fcl files in dunecore do not configure plugins in products above dunecore is to make a new services_common_dune_withsim.fcl that #includes services_common_dune.fcl and also the ones in dunsim, and take out the dunesim includes from services_common_dune.fcl. The same would be done for the ones in dunecalib, duneopdet, and duneprototypes. The only headache then is to change any #includes of services_common_dune.fcl to point to the specific ones. I just grepped for instances of that include now and found these: dunecore/dunecore/Utilities/services_protodune_dualphase.fcl:#include "services_common_dune.fcl" So it looks like all of these can move to duneprototypes (one already is there). |
The services_*.fcl files mentioned in my previous comment are all #included by dunecore/Utilities/services_dune.fcl. This file is in turn #included by a great many other fcl files. The ones in higher products on the list, like those in dunesw, are not problematic, but the ones in say dunesim or duneopdet are troubling if we move these detector-specific fcls to duneprototypes. But some are not prototypes, like the dunefd ones. |
Possible solution: we make services_common_.fcl files that encapsulate the services for the repo |
No description provided.
The text was updated successfully, but these errors were encountered: