Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move root --> h5 converter/formatter script into larnd-sim #26

Open
krwood opened this issue Aug 8, 2023 · 2 comments
Open

move root --> h5 converter/formatter script into larnd-sim #26

krwood opened this issue Aug 8, 2023 · 2 comments
Assignees

Comments

@krwood
Copy link
Member

krwood commented Aug 8, 2023

The script run-convert2h5/convert_edepsim_roottoh5.py should be moved into larnd-sim. It is producing input h5 files especially formatted to work with larnd-sim and is therefore more appropriate there.

Then the entire run-convert2h5 could be removed and the conversion can happen at the beginning of the run-larnd-sim/run_larnd_sim.sh script.

@mjkramer mjkramer self-assigned this Aug 16, 2023
@alexbooth92
Copy link
Member

One thing to think about here is using more GPU node time than we need to. For NDLAr, larnd-sim needs the 80 GB NERSC nodes and the conversion step takes O (~ few hours) for each 10^16 POT (on CPU node). It's probably good practise to only rely on these 80 GB nodes only when we need to. If we put the conversion step in the larnd-sim grid script that's increasing the amount of time we are using the GPU nodes quite a bit.

@alexbooth92
Copy link
Member

Closed by accident. Reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants