Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ace6tao2] Comparison warning in CDR_Base.cpp #2219

Open
jwillemsen opened this issue Apr 15, 2024 · 4 comments
Open

[ace6tao2] Comparison warning in CDR_Base.cpp #2219

jwillemsen opened this issue Apr 15, 2024 · 4 comments

Comments

@jwillemsen
Copy link
Member

jwillemsen commented Apr 15, 2024

Warning in ACE using bcc32 on ace6tao2 branch, introduced by #2196

.\CDR_Base.cpp:
Warning W8012 .\CDR_Base.cpp 938: Comparing signed and unsigned values in function ACE_CDR::Fixed::from_string(const char *)
@mitza-oci
Copy link
Member

Both sides of the comparison are unsigned.
Is there a CI build that shows the warning - or could one be added?

@jwillemsen
Copy link
Member Author

Working on new CI builds, need to create first a base line. Are they different sizes, if so, one could be promoted to signed before the comparison

@jwillemsen
Copy link
Member Author

@iguessthislldo
Copy link
Member

It's size_t and an unsigned char. Why would a compiler change the signedness (apparently that's a real word) of a value and then complain about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants