Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #2155

Open
elfring opened this issue Oct 29, 2023 · 3 comments
Open

reserved identifier violation #2155

elfring opened this issue Oct 29, 2023 · 3 comments

Comments

@elfring
Copy link

elfring commented Oct 29, 2023

I would like to point out that identifiers like “_AST_DECL_AST_DECL_HH” and “_COMM_MANAGER_H” do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
@mitza-oci
Copy link
Member

There are uses of preprocessor identifiers (and probably others) that do not conform to what the standard requires because they're reserved. I think a contribution to change this would be welcome.

@elfring
Copy link
Author

elfring commented Nov 1, 2023

💭 Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

@jwillemsen
Copy link
Member

Feel free to use a tool to make a proposed pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwillemsen @elfring @mitza-oci