Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return errno directly with seccomp filters #793

Closed
quantum5 opened this issue Dec 27, 2020 · 2 comments · Fixed by #890
Closed

Return errno directly with seccomp filters #793

quantum5 opened this issue Dec 27, 2020 · 2 comments · Fixed by #890

Comments

@quantum5
Copy link
Member

libseccomp's seccomp_rule_add supports an action called SCMP_ACT_ERRNO(errno), so all our handlers that generates errnos could theoretically be handled in seccomp.

@Xyene
Copy link
Member

Xyene commented Dec 28, 2020

I considered this before, but I don't think we have a good enough ptbox testing story currently. I'd be worried about the ptrace-only errno implementations bitrotting unnoticed.

@Xyene Xyene mentioned this issue Aug 28, 2021
4 tasks
@Xyene
Copy link
Member

Xyene commented Aug 28, 2021

Given #871 is in the pipeline, we can commit to dropping the ptrace-only backend and go ahead with this.

quantum5 added a commit that referenced this issue Sep 7, 2021
quantum5 added a commit that referenced this issue Sep 7, 2021
quantum5 added a commit that referenced this issue Sep 7, 2021
quantum5 added a commit that referenced this issue Sep 8, 2021
quantum5 added a commit that referenced this issue Sep 8, 2021
quantum5 added a commit that referenced this issue Sep 8, 2021
quantum5 added a commit that referenced this issue Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants