Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map page skeleton #45

Merged
merged 17 commits into from
Apr 28, 2020
Merged

Map page skeleton #45

merged 17 commits into from
Apr 28, 2020

Conversation

AdamJonsson
Copy link
Member

@AdamJonsson AdamJonsson commented Apr 22, 2020 •
edited
Loading

Just a few notes:

  • Have not tested if the map works on Android.
  • The ref error in snapping-scroll component seems to be a bug. I can still run the code IOS but have not tested if it works on Android.
  • The web version of the app (Expo) now crashes because it seems that MapView does not exist on browsers.

@AdamJonsson AdamJonsson requested a review from ellaklara April 22, 2020 12:22
@AdamJonsson AdamJonsson self-assigned this Apr 22, 2020
@AdamJonsson AdamJonsson linked an issue Apr 22, 2020 that may be closed by this pull request
Find task page (Map page) #29
Closed
ellaklara
ellaklara reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@ellaklara ellaklara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Just a few suggestions and comments.
I'm not supposed to be able to test the geolocation, right?

src/components/map.tsx Show resolved Hide resolved
src/components/snapping-scroll.tsx Show resolved Hide resolved
src/pages/find-task-page.tsx Outdated Show resolved Hide resolved
src/pages/find-task-page.tsx Outdated Show resolved Hide resolved
src/pages/find-task-page.tsx Outdated Show resolved Hide resolved
src/components/snapping-scroll.tsx Outdated Show resolved Hide resolved
@AdamJonsson
Copy link
Member Author

Fixed your comments, created a new issue regarding the geolocation on android: #60. We maybe can wait with the marker as we should soon implement new markers: #13

@AdamJonsson AdamJonsson requested a review from ellaklara April 27, 2020 13:35
@ellaklara
Copy link
Member

ellaklara commented Apr 28, 2020 •
edited
Loading

It looks good!
Could you take a look at my last commit if it works for you? I added a permissions check which enables the location for android! It seems you had to do it manually, otherwise the user will not be prompted to enable location. But the map works for me too now :) @AdamJonsson

@AdamJonsson AdamJonsson merged commit 330a1cf into master Apr 28, 2020
@AdamJonsson AdamJonsson deleted the map-page-skeleton branch April 28, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellaklara ellaklara Awaiting requested review from ellaklara

Assignees

@AdamJonsson AdamJonsson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find task page (Map page)
2 participants
@AdamJonsson @ellaklara