From 071b865b00ad1f41fad9117fbb0d6e5a90a9cbe1 Mon Sep 17 00:00:00 2001 From: bichomartiano Date: Mon, 11 Dec 2023 17:09:48 +0100 Subject: [PATCH] delete jsymbollic --- README.md | 3 ++- docs/source/Feature_definition.md | 17 ++--------------- docs/source/Tutorial poprock.ipynb | 2 +- 3 files changed, 5 insertions(+), 17 deletions(-) diff --git a/README.md b/README.md index 946a4f30..305629c6 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,8 @@ To install the latest version of musif, just run which will download musif and all its necessary dependencies. ## music21 and jsymbollic features -Currently, musif is able to process and integrate basic music21 features. +Currently, musif is able to process and integrate basic music21 features. + For jsymbollic features, musif currently does not support the integration of these features, but a tutorial will be provided to manually merge them into musif's dataframe. # jsymbollic installation Java JRE >= 8 must be installed in your OS. Download Java Development Kit: https://www.oracle.com/es/java/technologies/downloads/ diff --git a/docs/source/Feature_definition.md b/docs/source/Feature_definition.md index b6fb6179..6c6c02b2 100644 --- a/docs/source/Feature_definition.md +++ b/docs/source/Feature_definition.md @@ -10,24 +10,11 @@ Finally, the _Stock module_ column lists the module distributed in `musif` and t Note that none of these features works on percussion instruments. In addition to the features in the present page, the features in the `'music21'` stock -module (first row of the below table) provide all the features from [`music21.features.native`](http://web.mit.edu/music21/doc/moduleReference/moduleFeaturesNative.html) -and [`music21.features.jSymbolic`](http://web.mit.edu/music21/doc/moduleReference/moduleFeaturesJSymbolic.html). The stock module -`'jsymbolic`, instead, provide the features extracted using -[`jSymbolic`](https://jmir.sourceforge.net/manuals/jSymbolic_manual/featureexplanations_files/featureexplanations.html) in the default configuration. - -You can provide custom `jSymbolic` configurations using the `jsymbolic_config_file` and `jsymbolic_max_ram` options in the [extraction configuration](Configuration.html). -When you use both the `jsymbolic` and `music21` features, `music21.features.jSymbolic` -is disabled, as it corresponds to a subset of musif's `jsymbolic` module. - -For the `jsymbolic` stock module, jSymbolic will be downloaded at the first run and you -will need Java JRE >= 8 installed in your OS. You can force the download of jSymbolic -and the check of Java installation by running `python -m -musif.extract.features.jsymbolic`. - +module (first row of the below table) provide all the features from [`music21.features.native`](http://web.mit.edu/music21/doc/moduleReference/moduleFeaturesNative.html). | **Column RegEx** | **Explanation** | Stock module | |------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------| -| `m21_.*` | Music21 features; only native features if `jsymbolic` is also included | `music21` | +| `m21_.*` | Music21 features | `music21` | | `FileName` | File name of the original score | `core` | | `Measures` | No. of measures of the piece | `core` | | `.+_SoundingMeasures` | No. of measures that have at least one note (not all silence) for a given part | `core` | diff --git a/docs/source/Tutorial poprock.ipynb b/docs/source/Tutorial poprock.ipynb index 30ae9219..61f99131 100644 --- a/docs/source/Tutorial poprock.ipynb +++ b/docs/source/Tutorial poprock.ipynb @@ -1914,7 +1914,7 @@ "name": "python", "nbconvert_exporter": "python", "pygments_lexer": "ipython3", - "version": "3.11.0" + "version": "3.10.8" }, "vscode": { "interpreter": {