Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grigoriev example is out of sync with spec #82

Open
fivegrant opened this issue Jan 30, 2024 · 4 comments · May be fixed by #83
Open

Grigoriev example is out of sync with spec #82

fivegrant opened this issue Jan 30, 2024 · 4 comments · May be fixed by #83

Comments

@fivegrant
Copy link
Contributor

The example Decapode in decapodes/example/grigoriev doesn't validate with the current schema. Additionally, decapodes/example/grigoriev/data may be missing a few files
@fivegrant
Copy link
Contributor Author

Note that it might be because the ACSet needs to be used for the AMR instead of the DecaExpr

@lukem12345
Copy link
Collaborator

Hey @fivegrant , can you share the script(s) that you used to generate the json files in decapodes/examples/grigoriev

@fivegrant
Copy link
Contributor Author

The examples were generated by @liunelson and @mattprintz . I just modified configuration.json, context.json, and combined.json very slightly to make sure the InterTypes for context and configuration aligned.

@lukem12345 lukem12345 linked a pull request Jan 31, 2024 that will close this issue
Draft
@lukem12345
Copy link
Collaborator

As discussed during today’s meeting, I’ll be shifting off the work on this issue to implement and document more physics examples. Anyone who gets this notification can pick up the work of finishing the generating script for the artifacts stored in the Grigoriev example folder. See PR#83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Llm/grigoriev DARPA-ASKEM/Model-Representations
2 participants
@fivegrant @lukem12345