refactor: improve error message for not found contracts (#27)

Cyfrin · Sep 17, 2024 · 47393d0 · 47393d0
1 parent 19ea262
commit 47393d0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/DevOpsTools.sol b/src/DevOpsTools.sol
@@ -60,7 +60,11 @@ library DevOpsTools {
         if (latestAddress != address(0)) {
             return latestAddress;
         } else {
-            revert("No contract deployed");
+            revert(
+                string.concat(
+                    "No contract named ", "'", contractName, "'", " has been deployed on chain ", vm.toString(chainId)
+                )
+            );
         }
     }
 

diff --git a/test/DevOpsToolsTest.t.sol b/test/DevOpsToolsTest.t.sol
@@ -35,7 +35,16 @@ contract DevOpsToolsTest is Test, ZkSyncChainChecker, FoundryZkSyncChecker {
     function testExpectRevertIfNoDeployment() public skipZkSync onlyVanillaFoundry {
         string memory contractName = "MissingContract";
         uint256 chainId = 1234;
-        vm.expectRevert("No contract deployed");
+        vm.expectRevert(
+            bytes.concat(
+                "No contract named ",
+                "'",
+                bytes(contractName),
+                "'",
+                " has been deployed on chain ",
+                bytes(vm.toString(chainId))
+            )
+        );
         DevOpsTools.get_most_recent_deployment(contractName, chainId, SEARCH_PATH);
     }