Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FNV128a #714

Open
kokizzu opened this issue May 18, 2022 · 5 comments
Open

Add FNV128a #714

kokizzu opened this issue May 18, 2022 · 5 comments

Comments

@kokizzu
Copy link

kokizzu commented May 18, 2022

No description provided.

@Cyan4973
Copy link
Owner

Is there one canonical version of FNV128a that could be employed for testing ?

Also : FNV128 (non-a) was already tested by rurban/smhasher, and we already know that the speed is not great and the mixing is not good, particularly for low bits, unsurprisingly, as for all FNV variants.
What's expected from another round of tests ?

@kokizzu
Copy link
Author

kokizzu commented Jul 25, 2023

I only know this https://github.com/segmentio/fasthash but that one is FNV1a not FNV128a

@kokizzu
Copy link
Author

kokizzu commented Jul 25, 2023

@Cyan4973
Copy link
Owner

this one is FNV128a https://github.com/deatil/lakego-admin/blob/3a43ae1ec7ad065ed0586a622d4bbd9824666b75/pkg/lakego-pkg/go-hash/hash/fnv.go#L103

Indeed, but it's coded in Go, making it difficult (to put it mildly) to use from a C-based program.

@kokizzu
Copy link
Author

kokizzu commented Jul 25, 2023

ah right this is C repo XD my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants