workspace: add CODEOWNERS
#331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A-workspace
hinto-janai
commented
Dec 3, 2024
CODEOWNERS
Outdated
Comment on lines
4
to
5
| # Default owner(s) of all code. | ||
| * @Boog900 @hinto-janai |
There was a problem hiding this comment.
Ordering matters, @Boog900 will appear at the top in the reviewers list and so-on.
CODEOWNERS
Outdated
Comment on lines
7
to
8
| # hinto-janai | ||
| /benches/** @hinto-janai |
There was a problem hiding this comment.
the last matching pattern takes the most precedence
In this case, changes to /benches will tag @hinto-janai first then everyone else (including everyone in *). I added myself for things I want to review.
Other notes:
- Users listed here must have write access (I tried adding @dimalinux for
cryptonight/although it doesn't work) - @SyntheticBird45 I did not add you in
*because every PR will tag you for review (and spam your email/notifications), did you want to be in this group or otherpaths/?
@Boog900 you need to enable the codeowner ruleset for main:
Cuprate/cuprateSettingsCode and automationRulesetsRequire a pull request before mergingRequire review from Code Owners
There was a problem hiding this comment.
@hinto-janai I'm already registered to any changes in the repository and receive mails accordingly. You can add me to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a
CODEOWNERSfile to the repo, see here for more documentation: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.Why