srcds Module is broken

[K1ller0561]

Operating System

Debian 12

AMP Version and Build Date

2.6.0.6 - 20241208.1

AMP Release Stream

Development

I confirm that

• I have searched for an existing bug report for this issue.
• I am using the latest available version of AMP.
• my operating system is up-to-date.

Intended Action

I try so start my srcds Module Servers (CSS, TF2, L4D2, GMOD, etc.) but this error comes: Source RCON failed to disconnect: Object reference not set to an instance of an object.

Expected Behaviour

That the srcds module is repaired. So a fix on the part of the developers.

Actual Behaviour

See log:

[05:01:05] [srcds Debug/11] : Working Directory: ./srcds/232330
[05:01:05] [srcds Debug/11] : Arguments: -game cstrike -console -usercon -ip 138.201.33.171 -port 10001 +rcon_password ********** +map surf_home_sweet_home_v4 +maxplayers 10 +hostname Server1 +sv_pure -1 +log on -tickrate 67 +logaddress_add 138.201.33.171:56897
[05:01:05] [srcds Debug/11] : Application state changed from PreStart to Starting
[05:01:05] [System Info/11] : AMP is up to date.
[05:01:07] [srcds Info/15] : Source RCON disconnecting...
[05:01:07] [srcds Error/15] : Source RCON failed to disconnect:
Object reference not set to an instance of an object.
[05:01:07] [RCON Error/15] : NullReferenceException
[05:01:07] [RCON Error/15] : [0] (NullReferenceException) : Object reference not set to an instance of an object.
[05:01:07] [RCON Error/15] : at RCONPlugin.SourceRconClient.Disconnect()
[05:01:07] [srcds Debug/15] : Application state changed from Starting to Stopped
[05:01:07] [System Warning/15] : Server failed to start 1/5

Reproduction

This problem is present since i upgraded to AMP 2.6, in AMP 2.5 is the srcds module running fine.

[IceOfWraith]

Click the update icon for the instance from the main ADS screen in your browser (where you see all the instances), then update the game server inside the instance. Start it again and share the entire log file, please.

[K1ller0561]

AMPLOG 2024-12-09 14-27-07.log

Steps are done, same problem …

[IceOfWraith]

The RCON error is due to the game server stopping so quickly. Something else is causing it to fail in the first place. I'd recommend running in a Docker container as it could be dependency related.

[Greelan]

That's not it, I've run the srcds module in docker and have had the same issues. Is AMP setting the PATH env var as needed for srcds servers on Linux?

[IceOfWraith]

When did this start becoming an issue?

[Greelan]

2.6, as noted by the OP

[IceOfWraith]

Yeah, I saw what they had, but you seemed to have more insight, so I was curious if it was something changed in AMP or in SRCDS that AMP needed to accommodate.

[Greelan]

Generic module templates continue to run, so no change in srcds itself

[Greelan]

Including templates for servers - like CSS and FOF - that fail in AMP

[K1ller0561]

Something must have been changed in AMP 2.6 that did not cause any errors in version 2.5. The srcds module has always run without errors.

[IceOfWraith]

The majority of AMP's foundation was changed in 2.6. So it's not surprising it started then. The question is what's not working with it. But I'll figure that out!

[K1ller0561]

The error message "Object reference not set to an instance of an object" typically occurs when you try to access a property or method on an object that is currently null.

#1096
same problem, but a csgo server.
i can't found this file in other srcds games.

[IceOfWraith]

Yeah that's unrelated. I just need to get to this bug. Dealing with another issue first.

[K1ller0561]

Ok, great. Thanks in advance for troubleshooting. I hope that it will be found. If there is anything new, please let me know 😀

[IceOfWraith]

I just want to note, Greelan made generic templates that are more up to date compared to the SRCDS module version for many of these game servers. If you create a new instance, it should be his instance type and still works fine. This should be done regardless since SRCDS module is being deprecated over time. But especially now since the module isn't working while I work to figure out the cause of this.

[cwagz]

I just want to note, Greelan made generic templates that are more up to date compared to the SRCDS module version for many of these game servers. If you create a new instance, it should be his instance type and still works fine. This should be done regardless since SRCDS module is being deprecated over time. But especially now since the module isn't working while I work to figure out the cause of this.

Will I get the correct template if I create a new instance using Counter-Strike: Source? When I go to create a new instance I see Counter-Strike:Source listed twice. Not sure how to tell which one is using the updated template that works.

[IceOfWraith]

One of those is the SRCDS module. In the next update that will only list one. If you make one of the instances, you can right click and Browse Datastore. If there's a file named GenericModule.kvp you have the newer one.

[Greelan]

Should be the second one in the list