Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the self link include query params? #144

Open
rduivenvoorde opened this issue Oct 11, 2023 · 1 comment
Open

Should the self link include query params? #144

rduivenvoorde opened this issue Oct 11, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@rduivenvoorde
Copy link

Hi, experimenting with a rather large db, which can practically (because of size) only be queried by using a spatial and temporal filter:

http://localhost:9000/collections/test.featureserv_metingen/items.json?limit=10000&bbox=4.44333975882750654,50.94963634583672274,5.44794455106176745,51.39568604304270849&filter=starttime%20%3E%20%272023-10-11T07%3A09%3A00.000%2B00%3A00%27%20and%20starttime%20%3C%20%272023-10-11t07%3A11%3A00.000%2B00%3A00%27

while bbox and filter work (in this case returning 1 query), the 'self' link in the result shows the full url: http://localhost:9000/collections/test.featureserv_metingen/items.json

I'm wondering if this should not include the other query params (same like when you are paging around in a dataset)?

@dr-jts
Copy link
Collaborator

dr-jts commented Oct 11, 2023

Yes, the self link should include all the query parameters. This is a bug.

@dr-jts dr-jts added the bug Something isn't working label Oct 11, 2023
@dr-jts dr-jts changed the title Should the self property of the self link not include query params? Should the self property of the self link include query params? Oct 11, 2023
@dr-jts dr-jts changed the title Should the self property of the self link include query params? Should the self link include query params? Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants