Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Is it intended that default watch sets NODE_ENV to production? #17

Open
ivawzh opened this issue May 19, 2018 · 4 comments
Open

Is it intended that default watch sets NODE_ENV to production? #17

ivawzh opened this issue May 19, 2018 · 4 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ivawzh
Copy link

ivawzh commented May 19, 2018

As title said, currently v0.6.0 by default run yarn watch with NODE_ENV=production start.

My assumption is most people will only use watch for development. Is there any reason it should not be development by default?

@ivawzh ivawzh changed the title Is it intended to default watch to run with NODE_ENV production? Is it intended that default watch sets NODE_ENV to production? May 19, 2018
@Cretezy
Copy link
Owner

Cretezy commented May 19, 2018

This is a bug. I'll fix it next Monday unless you got a PR for it, sorry!

@Cretezy Cretezy added bug Something isn't working good first issue Good for newcomers labels May 19, 2018
@Cretezy Cretezy self-assigned this May 19, 2018
@Cretezy
Copy link
Owner

Cretezy commented May 27, 2018

This seems to be fixed in 0.7.0, but I didn't actually try to fix anything related to this. I've noticed this on one of my projects but it seems to be fairly random.

I'm trying to pin-point more specifically what causes this and I definitely need your help with this one!

@Cretezy Cretezy added help wanted Extra attention is needed and removed good first issue Good for newcomers labels May 27, 2018
@craigmulligan
Copy link

Hey @Cretezy, I'm still seeing this behaviour in 0.7.2. Haven't had anytime to look at the code but give me a shout if I can help with debugging.

@Cretezy
Copy link
Owner

Cretezy commented Jul 16, 2018

I've been experiencing this too sometimes, and I'm unsure what is the root of it. If you can give me a sample that I can reproduce it would help greatly! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants