Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with SPIRAL hatching. (??!) #58

Open
golanlevin opened this issue Jun 26, 2020 · 2 comments
Open

Bug with SPIRAL hatching. (??!) #58

golanlevin opened this issue Jun 26, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@golanlevin
Copy link
Member

Hi @LingDong- ,
I made a demo to show off the animated stitch playback, examples/PEmbroider_animated_playback. It works great for SATIN, PARALLEL, and CONCENTRIC. However, it is doing something really weird and wrong with SPIRAL. Check it out, I'm using Theodore Gray's polygon:

Screen Shot 2020-06-26 at 1 41 59 AM

Screen Shot 2020-06-26 at 1 41 43 AM

Screen Shot 2020-06-26 at 1 41 25 AM

Screen Shot 2020-06-26 at 1 40 03 AM

Could you please have a look?

@golanlevin golanlevin added the bug Something isn't working label Jun 26, 2020
@LingDong-
Copy link
Collaborator

Wow that looks really crazy :P

I was aware that the SPIRAL mode is a bit glitchy, it works fine for simple shapes but often has a skewed ring or two with more complex shapes. (the algorithm works by interpolating concentric rings, and at sharp turns the angle could be set in the wrong direction).

But that one looks really terrible, I'll look into it to see if I can at least make it less crazy!

@golanlevin
Copy link
Member Author

OK, let me know how it goes.

If SPIRAL mode is 'experimental', that's OK -- we can label it as such in the documentation, or even (if the problem is serious) rename it something like SPIRAL_EXPERIMENTAL. We just need to be clear about what we think is solid, and what's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants