Improved Efficiency of the DiskUsage Metric #1647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR speeds up the
DiskUsage
metric.It turns out that if you have a lot of dirs/files in the current directory (the default target for the size inspection) especially the eval mode with
disk_usage_metrics(stream=True)
becomes super slow (the metric is computed every mini-batch).In my case it takes about 4 seconds for every inspection. I use the "du" command (it improves the timing of about 4x) if you are on Linux adding a warning in case the metric compute time exceeds 0.5 seconds.
Let me know if you think I should change anything.