Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ffcv improvements #1516

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

lrzpellegrini
Copy link
Collaborator

@lrzpellegrini lrzpellegrini commented Oct 11, 2023

Minor FFCV support improvements:

  • Add CenterCrop transformation to support variable-resolution datasets when loaded with CenterCrop as the first transform (a decoder that achieves something similar already exists in FFCV, but its behavior is not aligned with the torchvision one)
  • Fix the FFCV try_speed example
  • Add non_blocking=True in _unpack_minibatch of supervised problem and object detection

@coveralls
Copy link

coveralls commented Oct 11, 2023

Pull Request Test Coverage Report for Build 6484704365

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.5%

Totals Coverage Status
Change from base Build 6469972036: 0.0%
Covered Lines: 17566
Relevant Lines: 24229

💛 - Coveralls

@AntonioCarta
Copy link
Collaborator

looks good. You can merge it yourself once you fix the lint issue ;)

@AntonioCarta AntonioCarta merged commit 1c313f7 into ContinualAI:master Oct 11, 2023
12 checks passed
@lrzpellegrini lrzpellegrini deleted the ffcv_improvements branch October 16, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants