Skip to content

Early Stop #1195

Answered by Hua-rookie
Hua-rookie asked this question in Q&A
Nov 14, 2022 · 1 comments · 1 reply
Discussion options

You must be logged in to vote

I found that there might be a bug in EarlyStoppingPlugin.
I have observed that this bug only occurs when a 'return_task_id' is True, not when it is False, and the reasons are as follows:

This part of code is in early_stopping.py, we can see that only the last metrics would be update to the 'self.best_val'.

This part of code is in evaluation.py, we can see that if we choose to 'return_task_id', the last metrics will remain to be the metric of the last task but not the current task it should be.

I hope my understanding is correct.

Replies: 1 comment 1 reply

Comment options

You must be logged in to vote
1 reply
@AntonioCarta
Comment options

Answer selected by Hua-rookie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants