Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize StackedSet #1294

Open
letypequividelespoubelles opened this issue Sep 24, 2024 · 0 comments · May be fixed by #1296
Open

optimize StackedSet #1294

letypequividelespoubelles opened this issue Sep 24, 2024 · 0 comments · May be fixed by #1296
Assignees
@letypequividelespoubelles
Labels
perf Increase performances

Comments

@letypequividelespoubelles
Copy link
Collaborator

letypequividelespoubelles commented Sep 24, 2024 •
edited
Loading

Following discussion with on @ahamlat @matkt

The idea is to :

  • change the Set of operations since begiining of conflation to a List
  • when adding an op to the StackedSet, only check if already in the set of this tx
  • just before lineCount, delete duplicate in the thisTransaction set that are in the List of op since beiig of conflati
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@letypequividelespoubelles letypequividelespoubelles

Labels
perf Increase performances
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(StackeSet): less contains check to the full set of all operations Consensys/linea-tracer
1 participant
@letypequividelespoubelles