-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a relative path in Makefile to avoid corset executable conflicts #230
Comments
CI build fails
|
gusiri
changed the title
Use a specific path in Makefile to avoid corset executable conflicts
Use a relative path in Makefile to avoid corset executable conflicts
Jun 4, 2024
Closing as Corset can be located and tested at different relative locations (e.g, CI build docker) |
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current issue:
I found that using
CORSET ?= corset
and${CORSET}
in the Makefile can be problematic. It relies on the existence of an executable named "corset" in the current working directory, which can lead to conflicts with older versions or other executables with the same name (e.g., old executable generated bycargo install --path.
).This fixes issue #143
which might be caused by
${CORSET}
looking at another executable instead of../corset/target/release/corset
Proposed solution:
Let's change this to a specific path
../corset/target/release/corset
, similar to how it's done inprover/Makefile
. This ensures the Makefile always uses the intended executable from a clear location.For example, this will simply fix problems caused by corset executable conflicts
The text was updated successfully, but these errors were encountered: