-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to display module specific instruction names #252
Labels
Comments
we introduced |
So, currently there is a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following modules MMU / MMIO / OOB / EXP / ... have their own "instruction sets" independent of the EVM's instruction set, see the respective specifications. These are typically 2 byte integers (to differentiate them from the 1 byte opcodes of the EVM.) It would be great help if we could annotate these columns in
corset
to display the associated instruction names incorset inspect
. The current state of things makes it hard to deciper what is going on.Here is an example from the MMU module. The MMU module has 3 "instruction" columns
macro/MMU_INST
column it gets from the HUB, it contains values from the MMU's instruction setmicro/MMIO_INST
column it provides the MMIO module with, containing values from the MMIO's instruction setwcp/INST
column it provides the WCP module with, containing regular EVM instructionsThe stuff below is supposed to represent the sequence of MMU instructions the HUB creates in response to dealing with
KECCAK
,MSTORE
,KECCAK
,MSTORE
,LOG2
,REVERT
(withLOG2
deliberately not drawn due to reverting andREVERT
missingfor reasons I'm still investigatingdue to this being the root context of the transaction.)The text was updated successfully, but these errors were encountered: