Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local shapefiles + acronyms #13

Open
DreaJulca opened this issue Nov 2, 2016 · 2 comments
Open

Local shapefiles + acronyms #13

DreaJulca opened this issue Nov 2, 2016 · 2 comments

Comments

@DreaJulca
Copy link
Collaborator

DreaJulca commented Nov 2, 2016

Right now, they are stored in extdata. It may be more efficient in terms of library size (given the general < 5MB rule) and latency to use sysdata (via devtools::use_data()) for the shapefiles and add the acronyms to the Dydra repo. With that said, it may also be practical to just point to the location of the shapefiles for download by the user, or to include the acronyms in the sysdata file, and of course we could stick with the current approach (to be honest, however, I am leaning toward my first suggestion - dydra repo for acronyms, sysdata for shp).

@DreaJulca
Copy link
Collaborator Author

DreaJulca commented Nov 2, 2016

Also, the Metro-level shapefiles (USMSA, NUTSMetro) cannot be loaded:

Error in rgdal::readOGR(dsn = localPath, layer = "USMSA.shp") : 
  no features found
In addition: Warning message:
In ogrInfo(dsn = dsn, layer = layer, encoding = encoding, use_iconv = use_iconv,  :
  ogrInfo: all features NULL

(and of course, the NUTSMetro file does not exist).

To deal with this for the time being, I have temporarily suppressed metro-level shps.

@DreaJulca
Copy link
Collaborator Author

Partially closed: Shapefiles read in and stored in sysdata, need to decide on acronym storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant