Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryAsync and FetchAsync missing Overloads for Joins #715

Open
Rafael-Dabrowski opened this issue Jan 5, 2024 · 1 comment
Open

QueryAsync and FetchAsync missing Overloads for Joins #715

Rafael-Dabrowski opened this issue Jan 5, 2024 · 1 comment

Comments

@Rafael-Dabrowski
Copy link

We are currently looking forward to integrate PetaPoco in our projects. But we found that the Async API is missing a Key Features. Namely the possibility to configure Joining Criteria which is present in the Sync API through Fetch<T1, T2, TRet>(action, query) and described here: https://github.com/CollaboratingPlatypus/PetaPoco/wiki/Multi-Poco-Queries.

Is this on Purpose? Did we miss something? Are there Timelines to when this will be available?

Kind Regards

Rafael

@pleb
Copy link
Member

pleb commented Jan 7, 2024

@Rafael-Dabrowski, it's been a few years since I implemented Async support, so my memory in this area is a little rough. My best guess is that I focussed on the core APIs and left the few add-on APIs in the to-do basket. Feel free to try added support yourself, as we'd love a PR. Just remember to add tests if you attempt this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants