Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons don't appear with FSE themes #244

Open
MarinescuLucia opened this issue May 6, 2023 · 2 comments
Open

Icons don't appear with FSE themes #244

MarinescuLucia opened this issue May 6, 2023 · 2 comments
Labels
question Can be used to identify issues that are asking a question about the code or how to use the project.

Comments

@MarinescuLucia
Copy link

Description

The icons don't appear with FSE themes either in the editor or on the published page. Is this intentional for FSE themes?

Step-by-step reproduction instructions

  1. Install an FSE theme
  2. Go to the editor
  3. Select a menu item and add an icon to it
  4. Check that it doesn't appear in the editor or on the published page.

Screenshots, screen recording, code snippet or Help Scout ticket

Reported here.

Environment info

No response

Is the issue you are reporting a regression

No

@MarinescuLucia MarinescuLucia added the question Can be used to identify issues that are asking a question about the code or how to use the project. label May 6, 2023
@HardeepAsrani
Copy link
Member

Just adding a bit more context here for Vytis:

This functionality was part of https://github.com/Codeinwp/gutenberg-menu-icons and was shared between Otter & WP Menu Icons for some time. Later we decided to manage it separately in Otter to avoid the complex setup Otter had and archived that repo.

@kushh23
Copy link

kushh23 commented Nov 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Can be used to identify issues that are asking a question about the code or how to use the project.
Projects
None yet
Development

No branches or pull requests

3 participants