Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review changelog to improve formatting #341

Closed
selul opened this issue Aug 29, 2024 · 3 comments · Fixed by #366
Closed

Review changelog to improve formatting #341

selul opened this issue Aug 29, 2024 · 3 comments · Fixed by #366
Assignees
Milestone

Comments

@selul
Copy link
Contributor

selul commented Aug 29, 2024

Changelog has a few entries which is acting strange https://vertis.d.pr/i/8ARLxC, we can look into fixing the parsing or list the content as it is without tabs and such.

@selul selul added this to the v33.0.0 milestone Sep 3, 2024
@girishpanchal30 girishpanchal30 linked a pull request Sep 11, 2024 that will close this issue
6 tasks
@girishpanchal30
Copy link
Contributor

I've reviewed and fixed the changelog format issue.

Free: #366
Pro: https://github.com/Codeinwp/ppom-pro/pull/453

@selul
Copy link
Contributor Author

selul commented Sep 11, 2024

@girishpanchal30 I dont think this is enough, we need either to fix the parsing to be consistent or display changelog as it is without any tabs and anything.

The thing with edits on the changelog is that it can always come back when a new version is using some strange chars/format.

@girishpanchal30
Copy link
Contributor

@selul I've fixed the parsing issue, please check with this PR #366

@selul selul mentioned this issue Sep 26, 2024
@selul selul closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants