Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV] Remove Sweetalert2 deps #340

Closed
Soare-Robert-Daniel opened this issue Aug 27, 2024 · 1 comment · Fixed by #342
Closed

[DEV] Remove Sweetalert2 deps #340

Soare-Robert-Daniel opened this issue Aug 27, 2024 · 1 comment · Fixed by #342
Labels
small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Milestone
v33.0.0

Comments

@Soare-Robert-Daniel
Copy link
Contributor

Description

Remove the Sweetalert2 popup and replace it with a simple Popup implementation.
@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Aug 27, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Aug 29, 2024 that will close this issue
Remove SweetAlert #342
Merged
6 tasks
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this issue Aug 29, 2024
Merged
6 tasks
@selul selul added this to the v33.0.0 milestone Sep 3, 2024
@rodica-andronache
Copy link

@Soare-Robert-Daniel it's working well 👍

@selul selul mentioned this issue Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
v33.0.0
Development

Successfully merging a pull request may close this issue.

Remove SweetAlert Codeinwp/woocommerce-product-addon
3 participants
@rodica-andronache @selul @Soare-Robert-Daniel